From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Anthony Perard" <anthony.perard@citrix.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"Julien Grall" <julien@xen.org>,
"Leif Lindholm" <leif@nuviainc.com>,
"Peter Grehan" <grehan@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Ray Ni" <ray.ni@intel.com>, "Rebecca Cran" <rebecca@bsdio.com>,
"Sami Mujawar" <sami.mujawar@arm.com>,
"Zhichao Gao" <zhichao.gao@intel.com>
Subject: Re: [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements
Date: Mon, 4 Jan 2021 17:12:29 +0100 [thread overview]
Message-ID: <09ea04f1-c83e-bf71-8dae-e16aec659844@arm.com> (raw)
In-Reply-To: <20210104154235.31785-1-lersek@redhat.com>
On 1/4/21 4:42 PM, Laszlo Ersek wrote:
> Repo: https://pagure.io/lersek/edk2.git
> Branch: shell_usability_improvements
>
> This series addresses various usability shortcomings that I've recently
> run into, while working with large directory trees on FAT and/or
> virtio-fs in the UEFI shell.
>
> * add file buffering to the COMP command
> https://bugzilla.tianocore.org/show_bug.cgi?id=3123
>
> * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000
> https://bugzilla.tianocore.org/show_bug.cgi?id=3125
>
> * Shell: pathname / filename sorting
> https://bugzilla.tianocore.org/show_bug.cgi?id=3151
>
> * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG
> builds
> https://bugzilla.tianocore.org/show_bug.cgi?id=3152
>
> Beyond testing the series locally, I've also heavily subjected it to
> local CI runs, including ECC (relevant for ShellPkg).
>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (8):
> ShellPkg/Comp: add file buffering
> OvmfPkg: raise PcdShellFileOperationSize to 128KB
> ArmVirtPkg: raise PcdShellFileOperationSize to 128KB
> ShellPkg/ShellCommandLib: add ShellSortFileList()
> ShellPkg/Ls: sort output by FileName in non-SFO mode
> ShellPkg/ShellProtocol: sort files by FullName in
> RemoveDupInFileList()
> OvmfPkg: disable list length checks in NOOPT and DEBUG builds
> ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds
>
Where needed,
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
--
Ard.
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
> OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
> OvmfPkg/OvmfPkgIa32.dsc | 3 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 3 +
> OvmfPkg/OvmfPkgX64.dsc | 3 +
> OvmfPkg/OvmfXen.dsc | 1 +
> ShellPkg/Application/Shell/ShellProtocol.c | 16 +
> ShellPkg/Include/Library/ShellCommandLib.h | 81 +++++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 312 ++++++++++++++++++++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h | 19 ++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf | 1 +
> ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 127 +++++++-
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 +
> ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 14 +
> ShellPkg/ShellPkg.dsc | 1 +
> 18 files changed, 584 insertions(+), 4 deletions(-)
>
>
> base-commit: 0785c619a58a450091d2bf6755591012533b80b8
>
next prev parent reply other threads:[~2021-01-04 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:42 [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements Laszlo Ersek
2021-01-04 15:42 ` [PATCH 1/8] ShellPkg/Comp: add file buffering Laszlo Ersek
2021-01-11 1:24 ` Gao, Zhichao
2021-01-04 15:42 ` [PATCH 2/8] OvmfPkg: raise PcdShellFileOperationSize to 128KB Laszlo Ersek
2021-01-04 15:42 ` [PATCH 3/8] ArmVirtPkg: " Laszlo Ersek
2021-01-04 15:42 ` [PATCH 4/8] ShellPkg/ShellCommandLib: add ShellSortFileList() Laszlo Ersek
2021-01-13 3:03 ` Gao, Zhichao
2021-01-04 15:42 ` [PATCH 5/8] ShellPkg/Ls: sort output by FileName in non-SFO mode Laszlo Ersek
2021-01-13 3:04 ` Gao, Zhichao
2021-01-04 15:42 ` [PATCH 6/8] ShellPkg/ShellProtocol: sort files by FullName in RemoveDupInFileList() Laszlo Ersek
2021-01-13 3:04 ` Gao, Zhichao
2021-01-04 15:42 ` [PATCH 7/8] OvmfPkg: disable list length checks in NOOPT and DEBUG builds Laszlo Ersek
2021-01-04 15:42 ` [PATCH 8/8] ArmVirtPkg: " Laszlo Ersek
2021-01-04 16:12 ` Ard Biesheuvel [this message]
2021-01-08 8:34 ` [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ea04f1-c83e-bf71-8dae-e16aec659844@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox