Re: [PATCH 0/5] NetworkPkg: HTTP and TLS updates

[Laszlo Ersek <lersek@redhat.com>]

Siyuan, Jiaxin,

do you have any comments please?

Thanks,
Laszlo

On 03/22/18 17:39, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: http_and_tls_updates
> 
> Patch #4 fixes TianoCore BZ#909
> <https://bugzilla.tianocore.org/show_bug.cgi?id=909>.
> 
> Patches #2 and #3 are cleanups / preparation for patch #4.
> 
> Patch #1 fixes an independent typo that I noticed in the code while
> configuring my DHCP server for HTTP(S) booting. It's isolated, so I put
> it first in the series.
> 
> Patch #5 is preparation for future platform enablement, so that a
> platform can create both "TlsCaCertificate" and "HttpTlsCipherList"
> variables on every boot from scratch as volatile variables (without
> flash varstore footprint).
> 
> I regression-tested this series with a successful HTTPS boot of an ISO
> image from OVMF, using a DER-formatted self-signed certificate that I
> enrolled with TlsAuthConfigDxe.
> 
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (5):
>   NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing
>   NetworkPkg/HttpDxe: use error handler epilogue in
>     TlsConfigCertificate()
>   NetworkPkg/HttpDxe: drop misleading comment / status code in cert
>     config
>   NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before
>     use
>   NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable
>     attributes
> 
>  NetworkPkg/HttpBootDxe/HttpBootDhcp4.c          |  4 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf                  |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c               | 74 ++++++++++++++++++--
>  NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++--
>  4 files changed, 80 insertions(+), 16 deletions(-)
>