From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79C202035BA3F for ; Tue, 27 Mar 2018 02:25:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DBFD722C8; Tue, 27 Mar 2018 09:32:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 791DA1DB25; Tue, 27 Mar 2018 09:32:35 +0000 (UTC) From: Laszlo Ersek To: Siyuan Fu , Jiaxin Wu Cc: edk2-devel-01 References: <20180322163933.29122-1-lersek@redhat.com> Message-ID: <09f1858d-51db-9a3d-5d78-8dd322dec2bf@redhat.com> Date: Tue, 27 Mar 2018 11:32:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322163933.29122-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 27 Mar 2018 09:32:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 27 Mar 2018 09:32:36 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/5] NetworkPkg: HTTP and TLS updates X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 09:25:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Siyuan, Jiaxin, do you have any comments please? Thanks, Laszlo On 03/22/18 17:39, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: http_and_tls_updates > > Patch #4 fixes TianoCore BZ#909 > . > > Patches #2 and #3 are cleanups / preparation for patch #4. > > Patch #1 fixes an independent typo that I noticed in the code while > configuring my DHCP server for HTTP(S) booting. It's isolated, so I put > it first in the series. > > Patch #5 is preparation for future platform enablement, so that a > platform can create both "TlsCaCertificate" and "HttpTlsCipherList" > variables on every boot from scratch as volatile variables (without > flash varstore footprint). > > I regression-tested this series with a successful HTTPS boot of an ISO > image from OVMF, using a DER-formatted self-signed certificate that I > enrolled with TlsAuthConfigDxe. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > > Thanks, > Laszlo > > Laszlo Ersek (5): > NetworkPkg/HttpBootDxe: fix typo in DHCPv4 packet parsing > NetworkPkg/HttpDxe: use error handler epilogue in > TlsConfigCertificate() > NetworkPkg/HttpDxe: drop misleading comment / status code in cert > config > NetworkPkg/HttpDxe: sanity-check the TlsCaCertificate variable before > use > NetworkPkg/TlsAuthConfigDxe: preserve TlsCaCertificate variable > attributes > > NetworkPkg/HttpBootDxe/HttpBootDhcp4.c | 4 +- > NetworkPkg/HttpDxe/HttpDxe.inf | 3 +- > NetworkPkg/HttpDxe/HttpsSupport.c | 74 ++++++++++++++++++-- > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 15 ++-- > 4 files changed, 80 insertions(+), 16 deletions(-) >