From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.94]) by mx.groups.io with SMTP id smtpd.web10.1489.1681968432487542103 for ; Wed, 19 Apr 2023 22:27:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=4s968V6w; spf=pass (domain: os.amperecomputing.com, ip: 40.107.95.94, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpJMCNoGZs0VxI/TKWwRMj2ydG4bBReONDhr6yPPCTx2HHNSMVP2fNaib65gl0GQfiEI8X3R2SBj6pRVNdWApwMo995srAMCq8NwGLzbqwvV3O4NX8ELQ3NR8GIPXiTZ8vTkrHnl5OSlsR5eRsVUu4zwDRTIY8h6ybW65Jbv/Dl7lV7jRjEhPuKEyJRxynow84CZv2eHlWZAi1LsWtPCQhOhKSWbGjYTA5/lGOh6yRh/+0tZLpoacSkkuUErjVAaSKOXWl3GWltdvkSpbnQlkf+o2Gh0VjpsQWxDdY2/70tcnDonJSNeQkHMKnrO/7wek1ijxaMl9SGRa26dysOlFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rWOwRXQRC/CLNTUHsUFhFJA/bIyEo8zkuF6NPShJ+40=; b=f1vCmq5MBMBYaqH9UT9+eR/AI8/KrTuudv1Ox9aKLRZ5+DJ5UHYDVUZtfiBI5xtuWqOVjPyRHQoTVrf+yXJMjbuVD7q5LVKFAVxZWSoP8PVxBT6uc4bg761RpoBIjJCpoFJNfwD8+5F60SfyvlcO/1FMvOf+xtvPhuq/posFYul3pY3IUEoxIN3x+AKoqECjKSlYyc2Zyqw25v40dXIS7tTrIQN7JB052NlyJk8DDOkuNdppxcJYbLTWsD/9exNzwRXFCWfv2dE19ZGM+R+i8MsV3TB+8/ERrMUnNgT1bShVc+4aSZEFuSIaSRZe6XijX6+vBZkFcU9TllUR+E0cQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rWOwRXQRC/CLNTUHsUFhFJA/bIyEo8zkuF6NPShJ+40=; b=4s968V6wYTnxYW6/FOCgvHzYnV228DdNK6FkzXPKFp52jhobhJY9MlLQH73zdqApEwk7c3uHtXmEp0T0p4DGRd7M3Q4SvRjBlVa0h7vSlwOAFL0wiyzhEeaH6nWGa3PeAY/lPJBPHsmaTUv1pw5Bpmtf1Ta+X2MLfZNw2P5ThJM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by CH0PR01MB7138.prod.exchangelabs.com (2603:10b6:610:eb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 05:27:09 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::bb9e:46d1:ae4b:caf2%6]) with mapi id 15.20.6319.020; Thu, 20 Apr 2023 05:27:09 +0000 Message-ID: <09fe712a-44f9-58a4-71f4-0c08b2cc8e3b@amperemail.onmicrosoft.com> Date: Thu, 20 Apr 2023 12:26:58 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add Manageability PCDs To: abner.chang@amd.com, devel@edk2.groups.io Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy , Tinh Nguyen References: <20230418071543.1951-1-abner.chang@amd.com> <20230418071543.1951-13-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230418071543.1951-13-abner.chang@amd.com> X-ClientProxiedBy: SG2PR02CA0012.apcprd02.prod.outlook.com (2603:1096:3:17::24) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|CH0PR01MB7138:EE_ X-MS-Office365-Filtering-Correlation-Id: a1df5a8c-59c4-4fb5-9f7a-08db415fe328 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +29gLzxEVIuhEBFafABk+7AmhzYi8Aht4uaVbTdXiHY/+xh5r1+5Q2WitT4gby6EjOnRN9y5CQH2S+g2I7gdrUztmm5OBvI3rYgyATKnaGHfMKtHb7nqU/4YbbVBUEKoGy55DpSKCk1izhHMW6+cpiZKPagg1bwO4CCMUnBuQfhsfcxXbqBKZrjMy+hlhiJgrEmTsJjuiwA8U3mgANhduybmsl19JhDr9xc2F7pKTXsCR0k8Q0hO77PGQogUElcN0apTISSb9UQpLRDpKkt3XLiDGaiDvSE+RpCPHuklshZdZH3KOU4GNhUugqfVq/fQzkQdYKZW65IQr3wp2v2C2jehKHdgPBLMilrkTTht86ytKVXu8E4r7nq0gkl3rbloMnxwOMDfnUDrEw4O/R4dlMD9fpQJbgT0tzgY+S8YsoI2DvcYJGc+9h/MFK3ptgOsz0uF36+V+WT/CDgy6lS7Xrr1758xf0ymx11J7q7E7FXlM8M6qeKeP5WpiTCXh1ksfHqofVL9fvVWs+XY3XlYA5dnEBuzBwHFeGlMnOlgsoxry3ux6599K4UvMYcOTsRosa96pi1RrGgnlAsvqeCqmUOsXsKq18TG8dRkDLzOvnzAiCbxIqAAhQ3WmL7OPsXmAs6No5PnFu7Cz+8IN00dfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(346002)(39850400004)(396003)(376002)(451199021)(83170400001)(38100700002)(38350700002)(31696002)(6486002)(478600001)(6666004)(52116002)(6512007)(26005)(6506007)(53546011)(186003)(107886003)(5660300002)(8936002)(2906002)(316002)(54906003)(31686004)(41300700001)(4326008)(66946007)(66556008)(66476007)(8676002)(83380400001)(2616005)(42882007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2JPT0FTUU9rZ3k3QmowQnZicENqUWZDa3czLzMrZ2E4UFh4aG43MW5kaXlQ?= =?utf-8?B?eEludzUxMUk2ZkFWZTlNYmhjRmY1ZWFTVUdDTVlOMndKNkltUzBJOW1XL2w4?= =?utf-8?B?c0d2Zmp1WTRpVEY3clZKMnZCTE12S0RtZ1krMEtlUnhYTmJkVnpSR3VQVWxq?= =?utf-8?B?VWFPWXlSQTQ1UElqYzFxN0o5YTFqVEo1bkdIVzVJYmt0Vi9jdUVOemhlK1Iz?= =?utf-8?B?YStjelFuOS9uUE1KTEdoK3poTWZKTkQ1QUovL1BQaWFsVEl1SVkyZGVnZGdl?= =?utf-8?B?bmZwdGVDOEsxLy9hWTJ1OFVnS05zNnUyUkVHSkVPVFJ6T1grUTdHY09lbFM2?= =?utf-8?B?RHpNTUV5dUZvQ2J1ZVhxbTNxc1lseDVTbW9nUkpNQi9CWDFaQTdmdFN6aU5h?= =?utf-8?B?dFprL0pKMUp2blBSMDhaSUxzY3hITWExbWROcUM1QjNzcXI3ZEJ1YkxVOWJW?= =?utf-8?B?L24vbnFOQXVtUXNvOTgyZVhJcDhpdzVBM3BpdzdPNmFzMVpGRkhsNjB0YzFp?= =?utf-8?B?UjR4aGZyNHZQa3ZBajhWeWlVcHdzSzR1OWg4TGxxMy84WFRIVHdCTUNrNEo0?= =?utf-8?B?bVRWazR5MHd5TDdjRmt3dXh4KzdSTXpqc0FNZzFSY2Z3bkVEd0w1Q0hOZHlI?= =?utf-8?B?cGNzamZBVEN2NHBPR2w1S0NaN0dndHllNCs0V1FzRGwyWFNEMFdJMmY1LzJI?= =?utf-8?B?Z0trWEYyaDRxV2JSNzR1N3BRK3h6bU5OM1k1SktJWmc5QUNVMnArYlB6U05p?= =?utf-8?B?WVRsa2ZUWEVhYWtWTEIxam8yajRPOVJIM0xzZGcwWSttbTZlelloRWt3TGJF?= =?utf-8?B?TWk4RTZQcXM4ZC9CQlN6UDhqc28vQU9GNTUwTzh6dU5xWnR0OVZESEVzaWtI?= =?utf-8?B?VVFzamduVTJ2dkFnS3BrOWZvd3lab2xBMW1relcrUEhxS1pZQWEyZ1BKTFIv?= =?utf-8?B?VjFHUWZvQzNiOEkxZ0p1d1JPWTlIZjVnNU9NZXkwYXNGdWZCek5vYndBOFJY?= =?utf-8?B?ZTdqSU40N3lmZ21sejJabXRTenB6YWgzbUdXM1NUSUZHaG1BYk1pYUhYd3hX?= =?utf-8?B?VGhiSTF1amVqTlFMVzc1WWhVbmFjcHJKMlZZQzFER2swcHB1czM3S3dpZW1J?= =?utf-8?B?ekhYbndQTE1yOHhidmtkS3pyRDdoT2EyT25ybmM3RnpJNzkrMEdzZzRvRUxD?= =?utf-8?B?MDNsV0g5cEJzMXUxYkl4elBvZXdsVzVzQi9oRm1IdWw1VHNkZktBV2JlVWxC?= =?utf-8?B?NWt2L3RDb2RiYm1NWnBXby9XNXg5ajl0c3haMFpDcjRzTHpmVzlXUjJFME4y?= =?utf-8?B?Y2lZbUtYOUVBZGc0b29ObzRZcUgrOW9kNU5KdExaaWZWMGR1TlZYMXA4M0FE?= =?utf-8?B?MDJObHU3Qm5UVndORC85d2RtSzExZWIzZjA3TFRtdWxnY1g5M0RjbmZuaHVO?= =?utf-8?B?RlF5MFhhSDlvckovNHh6MHV1OUVYTGppRnBTeWJaYXJVT0llVzVJRkhVdXZ4?= =?utf-8?B?THNIME5rMDRBV0xMSjlCUGd2bVJYQTE1NWFldzJLQWYwL0ZBTHB2K29MRnc4?= =?utf-8?B?aUY1MGcwb0xrNWJMaThYU1haNnd0WjVOVFFGeE9kbTNYNDVJNHhGWDNod0I1?= =?utf-8?B?ajhCNXZFbWUrMTdYQnlzUlQ4VDV6RlhjbmVZN1dZVitiSzZqWjRuY1FRNkp3?= =?utf-8?B?YXJtVUxnUXgyTzlNNGh3cGo0K0tvaUh1SVVlYjlTeEsrQXBJRmxlcW1pKzZx?= =?utf-8?B?WFBlUk1yT3VlQWNwMDlpYjlBcU9vcjlMa1FxRXY2M2hiV3Nxc05HOHRWZXJ3?= =?utf-8?B?T05pWEZuSlNoTXpkSit5TFI1ZkpVNkVpQjJzSWNndXFXSHBIdTdGT3llOFMz?= =?utf-8?B?QVVGN200NGZEN2FPdmkxVG9vZlBNSWtjRHRWOXhvbVZHWlpGUXdGT3JJQzFh?= =?utf-8?B?UXFKN1AxQ0tNaW1tenVENit4ZzhMQ0RTRG5rQ0ZGUHErdkFWL2g3U3ArWkV1?= =?utf-8?B?bDMzYkpwYXowUUVFa0pNUW9Oak1yR202N1BnMTFxbitvRnJCdzFnRGtYTk56?= =?utf-8?B?M3J0clpIWGU3b1VML01sN0xPZ3VQY0Y1YVQvMW5yN1JodkFqUDY0cVRxUGc5?= =?utf-8?B?TE04d2o5Qm9zdnVXSVRsenpzZmNMWHR6Z1NxSHJ4dzJCRTRwZlN1T0NZUVEy?= =?utf-8?Q?e7dWwdrkEGA+MqzSq2tZF3A=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1df5a8c-59c4-4fb5-9f7a-08db415fe328 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 05:27:09.6232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FDnNiv7VDFkDSuT8CQqp0TL9wwTz4lXttJipeXI62QWjQgwkym1tQQPmIUH4p+9E2fuboNPybcxE35y6EC+27O9MB3bvcRGk2SGbuZ2ucD2xeb5O+qcaWEdwKjHpp+fN X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB7138 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen On 18/04/2023 14:15, abner.chang@amd.com wrote: > From: Abner Chang > > Add PCDs to control ManageabilityPkg > modules. > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Tinh Nguyen > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 8 ++++++++ > .../Include/Dsc/Manageability.dsc | 16 +++++++++++++++- > Features/ManageabilityPkg/ManageabilityPkg.dsc | 10 ++++++++++ > 3 files changed, 33 insertions(+), 1 deletion(-) > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 6b198e6a3c..6f58ab4f45 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -68,3 +68,11 @@ > # @Prompt MCTP KCS (Memory mapped) I/O base address > gManageabilityPkgTokenSpaceGuid.PcdMctpKcsBaseAddress|0xca2|UINT32|0x00000004 > > +[PcdsFeatureFlag] > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable|FALSE|BOOLEAN|0x10000001 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable|FALSE|BOOLEAN|0x10000002 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable|FALSE|BOOLEAN|0x10000003 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BOOLEAN|0x10000004 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BOOLEAN|0x10000005 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|FALSE|BOOLEAN|0x10000006 > + > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > index 0fab562844..5e7cdb885f 100644 > --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > @@ -25,14 +25,28 @@ > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > > [Components.IA32, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable == TRUE > ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > +!endif > > [Components.X64, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable == TRUE > ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > +!endif > > [Components.X64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable == TRUE > ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable == TRUE > ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable == TRUE > ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.inf > - ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > + ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index 959b3eabd2..41a8957954 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -28,6 +28,16 @@ > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE > > + # > + # Manageability modules > + # > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|TRUE > + > # > # Include common libraries > #