Re: reg: ISCSI Aborted attempt entry in IBFT Table

[Omkar K <omkark@amiindia.co.in>]

Hello Ting,

1. We did not enable MPIO.
2. in IScsiStart(), at this point

//
// Select the first login session. Abort others.
//
if (Private->Session == NULL) {
	Private->Session = Session;
	BootSelected     = AttemptConfigData->AttemptConfigIndex;
	//
	// Don't validate other attempt in multipath mode if one is success.
	//
	if (mPrivate->EnableMpio) {
	  break;
	}
} else {
	IScsiSessionAbort (Session);
	FreePool (Session);
}

other than one attempt per Nic, other sessions are aborted. Still, all the attempts are published in IBFT.
We can observe the issue when different targets are configured on one NIC where all the attempts are published in IBFT.
But, the issue disappeared when the aborted attempts are not published in IBFT.

Thanks,
Omkar

-----Original Message-----
From: Ye, Ting [mailto:ting.ye@intel.com] 
Sent: Monday, June 04, 2018 2:26 PM
To: Sivaraman Nainar; edk2-devel@lists.01.org
Cc: Omkar K; Madhan B. Santharam
Subject: RE: reg: ISCSI Aborted attempt entry in IBFT Table

Hi Siva,

Per design, the iSCSI multipath I/O will publish all configured attempts to IBFT, no matter the connection is success or fail currently.
Did you enable the MPIO when you configure the attempts? 

I am not clear what do you mean "aborted attempt".

Thanks,
Ting

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Sivaraman Nainar
Sent: Thursday, May 31, 2018 8:18 PM
To: edk2-devel@lists.01.org
Cc: Omkar K <omkark@amiindia.co.in>; Madhan B. Santharam <madhans@ami.com>
Subject: [edk2] reg: ISCSI Aborted attempt entry in IBFT Table

Hello all:
Here is the issue which requires clarification.
Issue Synopsis:
When there are more than one iSCSI target configured and Ibft table published with the connected and aborted attempt details, all the targets are not seen in ESXi and SLES OS. But in Windows it can see the targets connected.
Use case:
Target 1: IP : 192.xx.xx.31             Target 2 : IP : 192.xx.xx.1
NIC 1 configured with attempts Target 1 & Target 2 NIC 2 configured with attempts Target 1 Connection

Login

Ibft

Block Device in UEFI Shell

SLES / Esx OS

Windows

NIC1 Target1

Success

Published

Mounted

Target Seen



NIC1 Target2

Success

Published

Mounted

Target Seen



NIC1 Target1
NIC1 Target2
NIC2 Target1

Individual Login success

Published for all attempts (3)

NIC1 Target 1 NIC2 Target 1

None Seen

NIC1 Target 1 NIC2 Target 1


When the attempts which are login success but Aborted by ISCSI Driver are present in ibft table SLES and ESX not able to see the targets during Installation.
If the ISCSI Driver not adding the ibft entry for the aborted attempts then the targets are seen in Esx and SLES.
So it requires clarification that If the driver need to SKIP adding the aborted attempt entry to ibft or its OS responsibility to handle the invalid entries in ibft.
-Siva
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel