public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* BaseTools/ build broken due to unreviewed patch - PLEASE FIX
@ 2018-10-13  8:17 Ard Biesheuvel
  2018-10-13  8:44 ` Gao, Liming
  0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2018-10-13  8:17 UTC (permalink / raw)
  To: edk2-devel-01, Gao, Liming, Laszlo Ersek, Leif Lindholm,
	Kinney, Michael D, Zhu, Yonghong, stephano.cetola

Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f

  "BaseTools: update Test scripts support python3"

[which has never been sent out for review to the mailing list, as far
as I can tell] is breaking the BaseTools build

make -C Tests
make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests'
/bin/sh: 1: RunTests.py: not found
GNUmakefile:17: recipe for target 'test' failed
make[1]: *** [test] Error 127
make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests'
GNUmakefile:25: recipe for target 'Tests' failed
make: *** [Tests] Error 2
make: Leaving directory '/home/ard/build/edk2/BaseTools'

I tried reverting that patch alone, but that gives me

make -C Tests
make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests'
Traceback (most recent call last):
  File "RunTests.py", line 36, in <module>
    allTests = GetAllTestsSuite()
  File "RunTests.py", line 33, in GetAllTestsSuite
    return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()])
  File "RunTests.py", line 30, in GetPythonTestSuite
    return PythonToolsTests.TheTestSuite()
  File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py",
line 27, in TheTestSuite
    import CheckUnicodeSourceFiles
  File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py",
line 25, in <module>
    from Common.Misc import PathClass
  File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py",
line 27, in <module>
    from collections import UserDict as IterableUserDict
ImportError: cannot import name UserDict
GNUmakefile:17: recipe for target 'test' failed
make[1]: *** [test] Error 1
make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests'
GNUmakefile:25: recipe for target 'Tests' failed
make: *** [Tests] Error 2
make: Leaving directory '/home/ard/build/edk2/BaseTools'

Breaking the build for everyone with an unreviewed patch 2 days before
the plugfest is NOT OK.

Please fix or revert ASAP

(I suppose that the failing test is a false negative in this case, but
that is not really the point - my CI jobs are broken due to this and
so are many others, I imagine)


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-10-13 15:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-13  8:17 BaseTools/ build broken due to unreviewed patch - PLEASE FIX Ard Biesheuvel
2018-10-13  8:44 ` Gao, Liming
2018-10-13  8:46   ` Ard Biesheuvel
2018-10-13  8:57     ` Gao, Liming
2018-10-13  9:23     ` Gao, Liming
2018-10-13 12:18       ` Ard Biesheuvel
2018-10-13 15:12         ` Andrew Fish
2018-10-13 15:48           ` Gao, Liming
2018-10-13  9:22   ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox