From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B10311A1E2F for ; Sat, 22 Oct 2016 03:41:51 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2016 03:41:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,529,1473145200"; d="scan'208";a="1048413434" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 22 Oct 2016 03:41:50 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 22 Oct 2016 03:41:47 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 22 Oct 2016 03:41:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Sat, 22 Oct 2016 18:41:45 +0800 From: "Zeng, Star" To: Sean Brogan , "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem Thread-Index: AdIqXbpOUluo4wLNRc25Lw1FgoagFwATN4gA///m+4D//tBAQIAC4PwA//5MSbA= Date: Sat, 22 Oct 2016 10:41:45 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103959062D@shsmsx102.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14B497236@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103958FEAA@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJkNDQyZTQtNzg3OC00ZmZkLWFkODctNjJhMDMxMGIwYjgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRrbVJzcGhFemozRkFtTG5vaVdNTFJMVDVyMjJ4NEcxWmdtM2hoNEg1WjA9In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: question about a compressed Ffs3 file inside FFS2 filesystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2016 10:41:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I think adding the assert makes sense and makes the same issue to be caught= easily in the further, could you help file a bugzilla bug to track it? Thanks, Star -----Original Message----- From: Sean Brogan [mailto:sean.brogan@microsoft.com]=20 Sent: Saturday, October 22, 2016 12:40 AM To: Zeng, Star ; Gao, Liming ; e= dk2-devel@lists.01.org Subject: RE: [edk2] question about a compressed Ffs3 file inside FFS2 files= ystem Star, =20 Thanks. That was the issue and that fixed the problem. How about adding = an assert in PeiServicesLib? =20 MdePkg\Library\PeiServicesLib\PeiServicesLib.c ~ line 642=20 add the assert for the else case. =20 if (FvFormat !=3D NULL) { CopyGuid (&FvInfoPpi->FvFormat, FvFormat); } else { CopyGuid (&FvInfoPpi->FvFormat, &gEfiFirmwareFileSystem2Guid); //Since FileSystem 2 is being assumed check the FV //Check that the File system matches. =20 ASSERT(CompareGuid(&(((EFI_FIRMWARE_VOLUME_HEADER *)FvInfo)->FileSystem= Guid), &gEfiFirmwareFileSystem2Guid)); } Thanks again Sean This email message may contain confidential and privileged information.=A0 = Any unauthorized use is prohibited.=A0 If you are not the intended recipien= t, please contact the sender by reply email and destroy all copies of the o= riginal message. > -----Original Message----- > From: Zeng, Star [mailto:star.zeng@intel.com] > Sent: Thursday, October 20, 2016 6:02 PM > To: Sean Brogan ; Gao, Liming=20 > ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [edk2] question about a compressed Ffs3 file inside FFS2=20 > filesystem >=20 > Sean, >=20 > I guess the codes are reporting FvInfo PPI like below that makes the=20 > problem. >=20 > PeiServicesInstallFvInfoPpi( > NULL, > (VOID *)PcdGet32(PcdFlashFvXXXBase), > PcdGet32(PcdFlashFvXXXSize), > NULL, > NULL > ); >=20 > PeiServicesInstallFvInfoPpi() has below comments for FvFormat parameter. > @param FvFormat Unique identifier of the format of the mem= ory- > mapped > firmware volume. This parameter is option= al and > may be NULL. If NULL is specified, the > *EFI_FIRMWARE_FILE_SYSTEM2_GUID* format is= assumed. >=20 > I suggest the codes can be updated to: >=20 > PeiServicesInstallFvInfoPpi( > &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN)=20 > PcdGet32(PcdFlashFvXXXBase))->FileSystemGuid), > (VOID *)PcdGet32(PcdFlashFvXXXBase), > PcdGet32(PcdFlashFvXXXSize), > NULL, > NULL > ); >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Sean Brogan > Sent: Thursday, October 20, 2016 10:49 PM > To: Gao, Liming ; edk2-devel@lists.01.org > Subject: Re: [edk2] question about a compressed Ffs3 file inside FFS2=20 > filesystem >=20 > Liming, >=20 > Good catch not sure how that happened. Unfortunately now the problem=20 > doesn't make sense. The code should have IsFfs3Fv =3D True and the=20 > debug message that indicates the code path which ignores the section=20 > should not get executed. I'll look at it again today as the problem=20 > still exists, just my analysis is incorrect. >=20 > Current workaround is to make sure FFS2 sizes and guids are used=20 > everywhere so a problem with FFS3 is lurking somewhere. >=20 > Thanks > Sean >=20 >=20 > > -----Original Message----- > > From: Gao, Liming [mailto:liming.gao@intel.com] > > Sent: Thursday, October 20, 2016 1:27 AM > > To: Sean Brogan ; edk2-devel@lists.01.org > > Subject: RE: [edk2] question about a compressed Ffs3 file inside=20 > > FFS2 filesystem > > > > Sean: > > In MdePkg.dec, gEfiFirmwareFileSystem2Guid and=20 > > gEfiFirmwareFileSystem3Guid are defined below. > > gEfiFirmwareFileSystem2Guid =3D { 0x8c8ce578, 0x8a3d, 0x4f1c, { 0= x99, > 0x35, > > 0x89, 0x61, 0x85, 0xc3, 0x2d, 0xd3 }} > > gEfiFirmwareFileSystem3Guid =3D { 0x5473c07a, 0x3dcb, 0x4dca, { 0x= bd, > 0x6f, > > 0x1e, 0x96, 0x89, 0xe7, 0x34, 0x9a }} > > > > From the dump message, the root FV File System ID is > > 5473c07a-3dcb-4dca- bd6f-1e9689e7349a. It is FF3 file system. > > > > Thanks > > Liming > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On=20 > > > Behalf Of Sean Brogan > > > Sent: Thursday, October 20, 2016 7:09 AM > > > To: edk2-devel@lists.01.org > > > Subject: [edk2] question about a compressed Ffs3 file inside FFS2=20 > > > filesystem > > > > > > We have a condition that occurs when we boot where we see the=20 > > > following message and our boot fails because of it. > > > DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3=20 > > > formatted FV.\n")); > > > > > > Which is on line 773 of FwVol.c > > > ( > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pe > > > i/FwVol/FwVol.c ) > > > > > > The condition is caused by a large firmware volume (greater than > > > 16mb) that is compressed and put into a smaller FV (less than 16mb). > > > My question is why isn't this allowed (seems like a valid scenario). > > > Volinfo supports this and decodes binary fine. The PI Vol 3 spec=20 > > > has a section 3.2.2 EFI_FIRMWARE_FILE_SYSTEM3_GUID which says > > > FileSystem2 doesn't support large files but it seems that the code=20 > > > is not taking into account that the section is compressed and=20 > > > therefore you can have a large file inside a compressed section=20 > > > inside a > FV with File System2. > > > > > > Feedback/thoughts/comments/Bug? > > > > > > Here are some details of my scenario. > > > Compressed FV has filesystem =3D=3D 8c8ce578-8a3d-4f1c-9935- > 896185c32dd3 > > > (ffs3) > > > Non compressed FV has filesystem =3D=3D 5473c07a-3dcb-4dca-bd6f-=20 > > > 1e9689e7349a (ffs2) > > > > > > VolInfo dump of the Non Compressed FV showing the > nested/compressed > > > FV inside. > > > > > > Decoding > > > VolInfo Version 1.0 Build Build 20909 > > > Signature: _FVH (4856465F) > > > Attributes: 4FEFF > > > EFI_FVB2_READ_DISABLED_CAP > > > EFI_FVB2_READ_ENABLED_CAP > > > EFI_FVB2_READ_STATUS > > > EFI_FVB2_WRITE_DISABLED_CAP > > > EFI_FVB2_WRITE_ENABLED_CAP > > > EFI_FVB2_WRITE_STATUS > > > EFI_FVB2_LOCK_CAP > > > EFI_FVB2_LOCK_STATUS > > > EFI_FVB2_STICKY_WRITE > > > EFI_FVB2_MEMORY_MAPPED > > > EFI_FVB2_ERASE_POLARITY > > > EFI_FVB2_READ_LOCK_CAP > > > EFI_FVB2_READ_LOCK_STATUS > > > EFI_FVB2_WRITE_LOCK_CAP > > > EFI_FVB2_WRITE_LOCK_STATUS > > > EFI_FVB2_ALIGNMENT_16 > > > EFI_FVB2_ALIGNMENT_32 > > > EFI_FVB2_ALIGNMENT_64 > > > EFI_FVB2_ALIGNMENT_128 > > > EFI_FVB2_ALIGNMENT_4K > > > EFI_FVB2_ALIGNMENT_8K > > > EFI_FVB2_ALIGNMENT_16K > > > EFI_FVB2_ALIGNMENT_32K > > > EFI_FVB2_ALIGNMENT_1M > > > EFI_FVB2_ALIGNMENT_2M > > > EFI_FVB2_ALIGNMENT_4M > > > EFI_FVB2_ALIGNMENT_8M > > > EFI_FVB2_ALIGNMENT_256M > > > EFI_FVB2_ALIGNMENT_512M > > > EFI_FVB2_ALIGNMENT_1G > > > EFI_FVB2_ALIGNMENT_2G > > > Header Length: 0x00000048 > > > File System ID: 5473c07a-3dcb-4dca-bd6f-1e9689e7349a > > > Revision: 0x0002 > > > Number of Blocks: 0x00000028 > > > Block Length: 0x00010000 > > > Total Volume Size: 0x00280000 > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =3D=3D > > > File Name: 9E21FD93-9C72-4C15-8C4B-E77F1DB2D792 > > > File Offset: 0x00000048 > > > File Length: 0x001F3FFD > > > File Attributes: 0x00 > > > File State: 0xF8 > > > EFI_FILE_DATA_VALID > > > File Type: 0x0B EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE > > > ------------------------------------------------------------ > > > Type: EFI_SECTION_GUID_DEFINED > > > Size: 0x001F3FE5 > > > SectionDefinitionGuid: ee4e5898-3914-4259-9d6e-dc7bd79403cf > > > > > > DataOffset: 0x0018 > > > Attributes: 0x0001 > > > ------------------------------------------------------------ > > > Type: EFI_SECTION_RAW > > > Size: 0x00000FF8 > > > ------------------------------------------------------------ > > > Type: EFI_SECTION_FIRMWARE_VOLUME_IMAGE > > > Size: 0x01010008 > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =3D=3D > > > > > > Thanks > > > Sean > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel