From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC2421A1E43 for ; Thu, 27 Oct 2016 02:09:59 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP; 27 Oct 2016 02:09:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,404,1473145200"; d="scan'208";a="24642698" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 27 Oct 2016 02:09:59 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 02:09:59 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 27 Oct 2016 02:09:58 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Thu, 27 Oct 2016 17:09:57 +0800 From: "Zeng, Star" To: Laszlo Ersek , "Zhang, Chao B" CC: edk2-devel-01 , "Zeng, Star" Thread-Topic: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE() Thread-Index: AQHSL7wPUl12TZjy0Um5PFlaWzc/cKC7fZ8AgACGgbA= Date: Thu, 27 Oct 2016 09:09:56 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB04831039593491@shsmsx102.ccr.corp.intel.com> References: <20161026190504.9888-1-lersek@redhat.com> <20161026190504.9888-41-lersek@redhat.com> <1c78a137-2d0f-8ac2-da58-945639f1102e@redhat.com> In-Reply-To: <1c78a137-2d0f-8ac2-da58-945639f1102e@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 09:10:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oh, it is Reviewed-by: Star Zeng . :) Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Thursday, October 27, 2016 5:08 PM To: Zeng, Star ; Zhang, Chao B Cc: edk2-devel-01 Subject: Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to AR= RAY_SIZE() Star, Chao, On 10/26/16 21:04, Laszlo Ersek wrote: > Cc: Chao Zhang > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c=20 > b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c > index c4fbb649f1fd..792a1232aed9 100644 > --- a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c > +++ b/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c > @@ -421,7 +421,7 @@ AuthVariableLibInitialize ( > AuthVarLibContextOut->StructVersion =3D AUTH_VAR_LIB_CONTEXT_OUT_STRUC= T_VERSION; > AuthVarLibContextOut->StructSize =3D sizeof (AUTH_VAR_LIB_CONTEXT_OUT)= ; > AuthVarLibContextOut->AuthVarEntry =3D mAuthVarEntry; > - AuthVarLibContextOut->AuthVarEntryCount =3D sizeof (mAuthVarEntry) /=20 > sizeof (mAuthVarEntry[0]); > + AuthVarLibContextOut->AuthVarEntryCount =3D ARRAY_SIZE=20 > + (mAuthVarEntry); > mAuthVarAddressPointer[0] =3D (VOID **) &mPubKeyStore; > mAuthVarAddressPointer[1] =3D (VOID **) &mCertDbStore; > mAuthVarAddressPointer[2] =3D (VOID **) &mHashCtx; @@ -433,7 +433,7=20 > @@ AuthVariableLibInitialize ( > mAuthVarAddressPointer[8] =3D (VOID **) &(mAuthVarLibContextIn->CheckR= emainingSpaceForConsistency), > mAuthVarAddressPointer[9] =3D (VOID **) &(mAuthVarLibContextIn->AtRunt= ime), > AuthVarLibContextOut->AddressPointer =3D mAuthVarAddressPointer; > - AuthVarLibContextOut->AddressPointerCount =3D sizeof=20 > (mAuthVarAddressPointer) / sizeof (mAuthVarAddressPointer[0]); > + AuthVarLibContextOut->AddressPointerCount =3D ARRAY_SIZE=20 > + (mAuthVarAddressPointer); > =20 > return Status; > } >=20 can one of you guys please review this patch? Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel