Re: [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

["Zeng, Star" <star.zeng@intel.com>]

Hi Ray,

Add two minor comments inline.

Thanks,
Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Ruiyu Ni
> Sent: Monday, November 14, 2016 1:26 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry 
> in RSDT/XSDT
> 
> The ACPI code may reserve the first entry for a certain table (might 
> be FACS) to help with OS compatible issues.

FACS is in FADT according to ACPI spec.

> We need to skip the NULL table entry in RSDT/XSDT.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> ---
>  PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> index 2bb41e7..35e34b7 100644
> --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c
> @@ -1230,6 +1230,11 @@ ScanTableInSDT (
>      //
>      Table = 0;

How about to remove this superfluous line " Table = 0;"?

>      CopyMem (&Table, (VOID *) (EntryBase + Index * TablePointerSize), 
> TablePointerSize);
> +
> +    if (Table == NULL) {
> +      continue;
> +    }
> 
> +
>      if (Table->Signature == Signature) {
>        return Table;
>      }
> --
> 2.9.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel