From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A07B981EA8 for ; Thu, 17 Nov 2016 02:55:01 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP; 17 Nov 2016 02:55:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,653,1473145200"; d="scan'208";a="32386686" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 17 Nov 2016 02:55:06 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 02:55:06 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Nov 2016 02:55:06 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Thu, 17 Nov 2016 18:55:04 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "sean.brogan@microsoft.com" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT Thread-Index: AQHSPje6Ce4DHJraoEO+2JLjCJYnL6DYxVwAgAQ/QjA= Date: Thu, 17 Nov 2016 10:55:03 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB048310395B6F01@shsmsx102.ccr.corp.intel.com> References: <20161114052622.166556-1-ruiyu.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D58E77C35@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D58E77C35@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 10:55:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Add two minor comments inline. Thanks, Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Ruiyu Ni > Sent: Monday, November 14, 2016 1:26 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry=20 > in RSDT/XSDT >=20 > The ACPI code may reserve the first entry for a certain table (might=20 > be FACS) to help with OS compatible issues. FACS is in FADT according to ACPI spec. > We need to skip the NULL table entry in RSDT/XSDT. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Sean Brogan > --- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > index 2bb41e7..35e34b7 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > @@ -1230,6 +1230,11 @@ ScanTableInSDT ( > // > Table =3D 0; How about to remove this superfluous line " Table =3D 0;"? > CopyMem (&Table, (VOID *) (EntryBase + Index * TablePointerSize),=20 > TablePointerSize); > + > + if (Table =3D=3D NULL) { > + continue; > + } >=20 > + > if (Table->Signature =3D=3D Signature) { > return Table; > } > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel