public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed.
Date: Tue, 20 Dec 2016 08:02:35 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B7D3E4F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482220609-16280-1-git-send-email-eric.dong@intel.com>

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Dong, Eric 
Sent: Tuesday, December 20, 2016 3:57 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr b/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
index 48e9943..57f37be 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
@@ -154,7 +154,7 @@ formset
             questionid = KEY_TPM2_PCR_BANKS_REQUEST_0,
             prompt     = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA1),
             help       = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA1_HELP),
-            flags      = INTERACTIVE,
+            flags      = INTERACTIVE | RESET_REQUIRED,
             default    = 1,
     endcheckbox;
   endif;
@@ -164,7 +164,7 @@ formset
             questionid = KEY_TPM2_PCR_BANKS_REQUEST_1,
             prompt     = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA256),
             help       = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA256_HELP),
-            flags      = INTERACTIVE,
+            flags      = INTERACTIVE | RESET_REQUIRED,
             default    = 0,
     endcheckbox;
   endif;
@@ -174,7 +174,7 @@ formset
             questionid = KEY_TPM2_PCR_BANKS_REQUEST_2,
             prompt     = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA384),
             help       = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA384_HELP),
-            flags      = INTERACTIVE,
+            flags      = INTERACTIVE | RESET_REQUIRED,
             default    = 0,
     endcheckbox;
   endif;
@@ -184,7 +184,7 @@ formset
             questionid = KEY_TPM2_PCR_BANKS_REQUEST_3,
             prompt     = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA512),
             help       = STRING_TOKEN(STR_TCG2_PCR_BANK_SHA512_HELP),
-            flags      = INTERACTIVE,
+            flags      = INTERACTIVE | RESET_REQUIRED,
             default    = 0,
     endcheckbox;
   endif;
@@ -194,7 +194,7 @@ formset
             questionid = KEY_TPM2_PCR_BANKS_REQUEST_4,
             prompt     = STRING_TOKEN(STR_TCG2_PCR_BANK_SM3_256),
             help       = STRING_TOKEN(STR_TCG2_PCR_BANK_SM3_256_HELP),
-            flags      = INTERACTIVE,
+            flags      = INTERACTIVE | RESET_REQUIRED,
             default    = 0,
     endcheckbox;
   endif;
-- 
2.6.4.windows.1



      parent reply	other threads:[~2016-12-20  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20  7:56 [Patch] SecurityPkg Tcg2ConfigDxe: Force reset when PCR Allocation changed Eric Dong
2016-12-20  7:57 ` Yao, Jiewen
2016-12-20  8:02 ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B7D3E4F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox