From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99490823EC for ; Thu, 22 Dec 2016 18:01:34 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 22 Dec 2016 18:01:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,391,1477983600"; d="scan'208";a="21907533" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 22 Dec 2016 18:01:34 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Dec 2016 18:01:33 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 22 Dec 2016 18:01:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Fri, 23 Dec 2016 10:01:32 +0800 From: "Zeng, Star" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check. Thread-Index: AQHSXGprYLWHHbEq5U+ogsY9iNajiqEUyAZw Date: Fri, 23 Dec 2016 02:01:30 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B7EF602@shsmsx102.ccr.corp.intel.com> References: <1482421507-6704-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1482421507-6704-1-git-send-email-jiewen.yao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 02:01:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Yao, Jiewen=20 Sent: Thursday, December 22, 2016 11:45 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [PATCH] MdeModulePkg/CapsuleLib: remove ImageIndex check. UEFI specification does not require ImageIndex check, it only requires Imag= eTypeId check. Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeMod= ulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c index 3ba3b9c..af08886 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c @@ -1013,8 +1013,7 @@ ProcessFmpCapsuleImage ( continue; } =20 - if (CompareGuid(&ImageHeader->UpdateImageTypeId, &TempFmpImageIn= fo->ImageTypeId) && - ImageHeader->UpdateImageIndex =3D=3D TempFmpImageInfo->Image= Index) { + if (CompareGuid(&ImageHeader->UpdateImageTypeId,=20 + &TempFmpImageInfo->ImageTypeId)) { AbortReason =3D NULL; if (ImageHeader->Version >=3D EFI_FIRMWARE_MANAGEMENT_CAPSULE_= IMAGE_HEADER_INIT_VERSION) { if(ImageHeader->UpdateHardwareInstance !=3D 0){ -- 2.7.4.windows.1