From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C72B08240F for ; Fri, 23 Dec 2016 00:14:53 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP; 23 Dec 2016 00:14:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,392,1477983600"; d="scan'208";a="46083946" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 23 Dec 2016 00:14:53 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Dec 2016 00:14:52 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 23 Dec 2016 00:14:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Fri, 23 Dec 2016 16:14:50 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Kinney, Michael D" , Michael Zimmermann , "Fan, Jeff" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK Thread-Index: AQHSXFmldLRXCuDvIkS9hAPkb2apFKEUmMEAgACXcPA= Date: Fri, 23 Dec 2016 08:14:49 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B7EF7EE@shsmsx102.ccr.corp.intel.com> References: <1482414310-33036-1-git-send-email-star.zeng@intel.com> <734D49CCEBEEF84792F5B80ED585239D5B8622F8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B8622F8@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Execute key notify function at TPL_CALLBACK X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 08:14:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, Thanks for the comments, I just sent out the V2 patch series based on the d= isucssion, please help review them again. :) Thanks, Star -----Original Message----- From: Ni, Ruiyu=20 Sent: Friday, December 23, 2016 3:12 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Tian, Feng ; Kinney, Michael D ; Michael Zimmermann ; Fan, Jeff ; Zeng, Star Subject: RE: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK Star, I checked all your patches. My comments to Patch 1/5 also apply to your other patches. Regards, Ray >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 >Star Zeng >Sent: Thursday, December 22, 2016 9:45 PM >To: edk2-devel@lists.01.org >Cc: Ni, Ruiyu ; Tian, Feng ;=20 >Kinney, Michael D ; Michael Zimmermann=20 >; Fan, Jeff ; Zeng, Star=20 > >Subject: [edk2] [PATCH 0/5] Execute key notify function at TPL_CALLBACK > >Current implementation of keyboard driver executes key notify function=20 >in TimerHandler at TPL_NOTIFY. The code change is to make key notify=20 >function executed at TPL_CALLBACK to reduce the time occupied at=20 >TPL_NOTIFY. > >The code will signal KeyNotify process event if the key pressed matches=20 >any key registered and insert the KeyData to the EFI Key queue for=20 >notify, then the KeyNotify process handler will invoke key notify=20 >functions at TPL_CALLBACK. > >It can also address the problem raised at=20 >https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html > >Cc: Ruiyu Ni >Cc: Michael Kinney >Cc: Feng Tian >Cc: Jeff Fan >Cc: Michael Zimmermann > >Star Zeng (5): > MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK > MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK > IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at > TPL_CALLBACK > IntelFrameworkModulePkg KbDxe: Execute key notify func at=20 >TPL_CALLBACK > > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 9 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 47 +++++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 23 ++- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 75 ++++++++- > .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 17 +- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 7 +- > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 45 ++++++=20 > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c | 20 +++=20 > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 15 ++ > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 64 +++++++- > MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 17 +- > MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 10 +- > .../Universal/Console/TerminalDxe/Terminal.c | 25 ++- > .../Universal/Console/TerminalDxe/Terminal.h | 80 +++++++++- > .../Universal/Console/TerminalDxe/TerminalConIn.c | 177=20 > ++++++++++++++++++++- > 16 files changed, 622 insertions(+), 24 deletions(-) > >-- >2.7.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel