From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A63181B34 for ; Tue, 10 Jan 2017 02:06:42 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 10 Jan 2017 02:06:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,343,1477983600"; d="scan'208";a="51280821" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 10 Jan 2017 02:06:42 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 02:06:41 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 02:06:41 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Tue, 10 Jan 2017 18:06:39 +0800 From: "Zeng, Star" To: Chris Phillips , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number Thread-Index: AQHSaw24HUoJGyJcykOXJOnBF709QqExfFPg Date: Tue, 10 Jan 2017 10:06:39 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8156A5@shsmsx102.ccr.corp.intel.com> References: <386f0aa8-708b-46e6-b20d-77ae416355ba@AIA2PHNNRN.local> In-Reply-To: <386f0aa8-708b-46e6-b20d-77ae416355ba@AIA2PHNNRN.local> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to cover SKU Number X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 10:06:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Chri= s Phillips Sent: Tuesday, January 10, 2017 2:49 PM To: edk2-devel@lists.01.org Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2] [PATCH] MdePkg: Add comments for SMBIOS Type 3 structure to= cover SKU Number Starting with SMBIOS spec version 2.7, Type 3 added SKU Number. SKU Number is at a variable offset (depends on count and length of Containe= d Elements), so cannot add SKU Number to the SMBIOS_TABLE_TYPE3 structure. Adding comments to explain how to get SKU Number. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chris Phillips --- MdePkg/Include/IndustryStandard/SmBios.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/Indu= stryStandard/SmBios.h index c66422fc3a..a24713d214 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -2,7 +2,7 @@ Industry Standard Definitions of SMBIOS Table Specification v3.0.0. =20 Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
-(C) Copyright 2015 Hewlett Packard Enterprise Development LP
+(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made availabl= e under the terms and conditions of the BSD License that accompanies this = distribution. =20 The full text of the license may be found at @@ -467,7 +467,18 @@ typedef = struct { UINT8 NumberofPowerCords; UINT8 ContainedElementCount; UINT8 ContainedElementRecordLength; + // + // Can have 0 to (ContainedElementCount *=20 + ContainedElementRecordLength) contained elements // CONTAINED_ELEMENT ContainedElements[1]; + // + // Add for smbios 2.7 + // + // Since ContainedElements has a variable number of entries, must not=20 + define SKUNumber in // the structure. Need to reference it by=20 + starting at offset 0x15 and adding // (ContainedElementCount * Contained= ElementRecordLength) bytes. + // + // SMBIOS_TABLE_STRING SKUNumber; } SMBIOS_TABLE_TYPE3; =20 /// -- 2.11.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel