From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B76881BFF for ; Wed, 11 Jan 2017 17:33:39 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP; 11 Jan 2017 17:33:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="52007451" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2017 17:33:38 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Jan 2017 17:33:37 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Thu, 12 Jan 2017 09:33:35 +0800 From: "Zeng, Star" To: "Augustine, Linson P" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" , "Ni, Ruiyu" , "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 Thread-Index: AQHSa+qY406KFlCMPk2VGU/EvSzJsKEyesKAgAADa4CAAZGVEA== Date: Thu, 12 Jan 2017 01:33:33 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B815F98@shsmsx102.ccr.corp.intel.com> References: <20170111091014.9832-1-linson.augustine@hpe.com> <256aa7ac-bd7f-ed7a-507b-c09dcdd50425@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMBIOS record type 43 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 01:33:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Linson, The patch has been pushed at 713e4b007cb791829397522ad8f366dd1e08bee6, than= ks for the contribution. Star -----Original Message----- From: Augustine, Linson P [mailto:linson.augustine@hpe.com]=20 Sent: Wednesday, January 11, 2017 5:36 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Carsey, Jaben ; Ni, Ruiyu ;= Kinney, Michael D ; Gao, Liming Subject: RE: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMB= IOS record type 43 Star, I agree with this. Please help me to push this patch. Regards, Linson. -----Original Message----- From: Zeng, Star [mailto:star.zeng@intel.com] Sent: Wednesday, January 11, 2017 2:53 PM To: Augustine, Linson P ; edk2-devel@lists.01.org Cc: jaben.carsey@intel.com; ruiyu.ni@intel.com; michael.d.kinney@intel.com;= liming.gao@intel.com; star.zeng@intel.com Subject: Re: [edk2] [PATCH v2 1/1] MdePkg/SmBios.h: Add new defines for SMB= IOS record type 43 Linson, Add minor comments inline. On 2017/1/11 17:10, Linson Augustine wrote: > Added definitions for the new SMBIOS Type 43 record. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Augustine Linson P > --- > MdePkg/Include/IndustryStandard/SmBios.h | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > b/MdePkg/Include/IndustryStandard/SmBios.h > index c66422fc3a..debc85af6e 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -2,7 +2,7 @@ > Industry Standard Definitions of SMBIOS Table Specification v3.0.0. > > Copyright (c) 2006 - 2015, Intel Corporation. All rights=20 > reserved.
> -(C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +(C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made=20 > available under the terms and conditions of the BSD License that accompa= nies this distribution. > The full text of the license may be found at @@ -97,6 +97,7 @@=20 > WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPL= IED. > #define SMBIOS_TYPE_ADDITIONAL_INFORMATION 40 > #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define=20 > SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > +#define SMBIOS_TYPE_TPM_DEVICE 43 > > /// > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapte= r 3.3.43. > @@ -2359,6 +2360,21 @@ typedef struct { } SMBIOS_TABLE_TYPE42; > > /// > +/// TPM Device (Type 43). > +/// > +typedef struct { > + SMBIOS_STRUCTURE Hdr; > + UINT8 VendorID[4]; > + UINT8 MajorSpecVersion; > + UINT8 MinorSpecVersion; > + UINT32 FirmwareVersion1; > + UINT32 FirmwareVersion2; > + UINT8 Description; It is better to use "SMBIOS_TABLE_STRING Description" instead of "UINT8 Des= cription". If you agree that, you can have my Reviewed-by: Star Zeng . And you do not need to resend the patch, I will help push the patch with th= e line fixed if no others' comments. Thanks, Star > + UINT64 Characteristics; > + UINT32 OemDefined; > +} SMBIOS_TABLE_TYPE43; > + > +/// > /// Inactive (Type 126) > /// > typedef struct { > @@ -2420,6 +2436,7 @@ typedef union { > SMBIOS_TABLE_TYPE40 *Type40; > SMBIOS_TABLE_TYPE41 *Type41; > SMBIOS_TABLE_TYPE42 *Type42; > + SMBIOS_TABLE_TYPE43 *Type43; > SMBIOS_TABLE_TYPE126 *Type126; > SMBIOS_TABLE_TYPE127 *Type127; > UINT8 *Raw; >