From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE6D281E84 for ; Thu, 19 Jan 2017 02:27:49 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 19 Jan 2017 02:27:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,253,1477983600"; d="scan'208";a="32626181" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 19 Jan 2017 02:27:49 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 02:27:48 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 02:27:48 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Thu, 19 Jan 2017 18:27:39 +0800 From: "Zeng, Star" To: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Fan, Jeff" , "Tian, Feng" , "Ni, Ruiyu" , "Ma, Maurice" , "Agyeman, Prince" , "Steele, Kelly" , Leif Lindholm CC: "Gao, Liming" , Ard Biesheuvel , Laszlo Ersek , "Zeng, Star" Thread-Topic: [PATCH 0/7] Make the event empty function in UefiLib public Thread-Index: AQHScJCUfVTqwqc38EmF+BzSqozDFqE/m5JA Date: Thu, 19 Jan 2017 10:27:39 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B818420@shsmsx102.ccr.corp.intel.com> References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1484636920-180432-1-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/7] Make the event empty function in UefiLib public X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 10:27:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Please kindly help take a review to the patches. :) So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPkg. Thanks, Star -----Original Message----- From: Zeng, Star=20 Sent: Tuesday, January 17, 2017 3:09 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Gao, Liming ; K= inney, Michael D ; Fan, Jeff ; Tian, Feng ; Ni, Ruiyu ; Ma, M= aurice ; Agyeman, Prince ; = Steele, Kelly ; Leif Lindholm ; Ard Biesheuvel ; Laszlo Ersek Subject: [PATCH 0/7] Make the event empty function in UefiLib public REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D298 We found there are many event empty functions in EDK2 code base, these patc= hes are to make the event empty function in UefiLib public, then this event= empty function can be used to remove the duplication in drivers and other = libraries. In CorebootPayloadPkg/QuarkPlatformPkg/ArmPlatformPkg, EfiEventGroupSignal = from UefiLib can be used to remove the duplication of event empty function. Cc: Liming Gao Cc: Michael Kinney Cc: Jeff Fan Cc: Feng Tian Cc: Ruiyu Ni Cc: Maurice Ma Cc: Prince Agyeman Cc: Kelly Steele Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Laszlo Ersek Star Zeng (7): MdePkg UefiLib: Make the event empty function public IntelFrameworkPkg UefiLib: Make the event empty function public MdeModulePkg: Use EfiEventEmptyFunction from UefiLib IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib QuarkPlatformPkg: Use EfiEventGroupSignal from UefiLib ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++----------------= - .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- .../Universal/BdsDxe/BdsEntry.c | 20 +---------- .../Library/FrameworkUefiLib/UefiLib.c | 42 +++++++++++-------= ---- .../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +---------- .../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +-- MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 23 ++---------- MdeModulePkg/Core/Dxe/DxeMain.h | 18 +--------- MdeModulePkg/Core/Dxe/Event/Event.c | 4 +-- MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 19 ++-------- .../Un= iversal/Console/ConSplitterDxe/ConSplitter.c | 22 ++---------- .../Univers= al/Console/ConSplitterDxe/ConSplitter.h | 18 +--------- .../Universal/DriverSampleDxe/DriverSample.c | 20 ++--------- .../Universal/SetupBrowserDxe/Presentation.c | 20 ++--------- MdePkg/Include/Library/UefiLib.h | 18 +++++++++- MdePkg/Library/UefiLib/UefiLib.c | 42 +++++++++++-------= ---- MdePkg/Library/UefiLib/UefiLibInternal.h | 20 +---------- MdePkg/Library/UefiLib/UefiNotTiano.c | 10 +++--- .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- 21 files changed, 91 insertions(+), 321 deletions(-) -- 2.7.0.windows.1