* [PATCH] MdeModulePkg: Remove superfluous return statements
@ 2017-01-19 10:16 Thomas Huth
2017-01-19 10:22 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-01-19 10:16 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Star Zeng
If the code eventually returns "Status" anyway, it does not make
sense to explicitely return "Status" in case of an error, too.
(this patch has been created with Coccinelle)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 ---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 ---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 ---
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 ---
4 files changed, 12 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
index 51cff3c..ad6cdb1 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
@@ -1046,9 +1046,6 @@ NvmeControllerInit (
// One for blocking I/O, one for non-blocking I/O.
//
Status = NvmeCreateIoSubmissionQueue (Private);
- if (EFI_ERROR(Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
index 3f73194..9dbec10 100755
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
@@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed (
HsTiming = 1;
Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, ClockFreq);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
index d6d3bdb..5a9e0b2 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
@@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed (
HsTiming = 1;
Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index 7ef141f..01bec19 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart (
//
Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK));
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MdeModulePkg: Remove superfluous return statements
2017-01-19 10:16 [PATCH] MdeModulePkg: Remove superfluous return statements Thomas Huth
@ 2017-01-19 10:22 ` Zeng, Star
2017-01-20 5:58 ` Thomas Huth
0 siblings, 1 reply; 5+ messages in thread
From: Zeng, Star @ 2017-01-19 10:22 UTC (permalink / raw)
To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Tian, Feng, Zeng, Star
With the typo "explicitely" fixed in the commit log,
Reviewed-by: Star Zeng <star.zeng@intel.com>
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Huth
Sent: Thursday, January 19, 2017 6:16 PM
To: edk2-devel@ml01.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements
If the code eventually returns "Status" anyway, it does not make sense to explicitely return "Status" in case of an error, too.
(this patch has been created with Coccinelle)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 ---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 ---
MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 ---
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 ---
4 files changed, 12 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
index 51cff3c..ad6cdb1 100644
--- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
+++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
@@ -1046,9 +1046,6 @@ NvmeControllerInit (
// One for blocking I/O, one for non-blocking I/O.
//
Status = NvmeCreateIoSubmissionQueue (Private);
- if (EFI_ERROR(Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
index 3f73194..9dbec10 100755
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
@@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed (
HsTiming = 1;
Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, ClockFreq);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
index d6d3bdb..5a9e0b2 100644
--- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
+++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
@@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed (
HsTiming = 1;
Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index 7ef141f..01bec19 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart (
//
Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK));
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
--
1.8.3.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] MdeModulePkg: Remove superfluous return statements
2017-01-19 10:22 ` Zeng, Star
@ 2017-01-20 5:58 ` Thomas Huth
2017-01-20 6:02 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-01-20 5:58 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@ml01.01.org; +Cc: Tian, Feng
On 19.01.2017 11:22, Zeng, Star wrote:
> With the typo "explicitely" fixed in the commit log,
Oh, right, stupid me ;-) Could you maybe fix that when picking up the
patch (since I can't commit this on my own)? Or shall I rather resend
the patch?
Thanks,
Thomas
> Reviewed-by: Star Zeng <star.zeng@intel.com>
>
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Huth
> Sent: Thursday, January 19, 2017 6:16 PM
> To: edk2-devel@ml01.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements
>
> If the code eventually returns "Status" anyway, it does not make sense to explicitely return "Status" in case of an error, too.
> (this patch has been created with Coccinelle)
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 ---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 ---
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 ---
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 ---
> 4 files changed, 12 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> index 51cff3c..ad6cdb1 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> @@ -1046,9 +1046,6 @@ NvmeControllerInit (
> // One for blocking I/O, one for non-blocking I/O.
> //
> Status = NvmeCreateIoSubmissionQueue (Private);
> - if (EFI_ERROR(Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> index 3f73194..9dbec10 100755
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> @@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> index d6d3bdb..5a9e0b2 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> @@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> index 7ef141f..01bec19 100644
> --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> @@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart (
> //
> Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
> ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAGENTA, EFI_BLACK));
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> --
> 1.8.3.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MdeModulePkg: Remove superfluous return statements
2017-01-20 5:58 ` Thomas Huth
@ 2017-01-20 6:02 ` Zeng, Star
2017-01-20 7:31 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Zeng, Star @ 2017-01-20 6:02 UTC (permalink / raw)
To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Tian, Feng, Zeng, Star
No need to resend path, I can help push it with the typo fixed.
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Huth
Sent: Friday, January 20, 2017 1:58 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@ml01.01.org
Cc: Tian, Feng <feng.tian@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements
On 19.01.2017 11:22, Zeng, Star wrote:
> With the typo "explicitely" fixed in the commit log,
Oh, right, stupid me ;-) Could you maybe fix that when picking up the patch (since I can't commit this on my own)? Or shall I rather resend the patch?
Thanks,
Thomas
> Reviewed-by: Star Zeng <star.zeng@intel.com>
>
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Thomas Huth
> Sent: Thursday, January 19, 2017 6:16 PM
> To: edk2-devel@ml01.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return
> statements
>
> If the code eventually returns "Status" anyway, it does not make sense to explicitely return "Status" in case of an error, too.
> (this patch has been created with Coccinelle)
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 ---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 ---
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 ---
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 ---
> 4 files changed, 12 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> index 51cff3c..ad6cdb1 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> @@ -1046,9 +1046,6 @@ NvmeControllerInit (
> // One for blocking I/O, one for non-blocking I/O.
> //
> Status = NvmeCreateIoSubmissionQueue (Private);
> - if (EFI_ERROR(Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> index 3f73194..9dbec10 100755
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> @@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming,
> ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> index d6d3bdb..5a9e0b2 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> @@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git
> a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> index 7ef141f..01bec19 100644
> --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> @@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart (
> //
> Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
> ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> (EFI_MAGENTA, EFI_BLACK));
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> --
> 1.8.3.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MdeModulePkg: Remove superfluous return statements
2017-01-20 6:02 ` Zeng, Star
@ 2017-01-20 7:31 ` Zeng, Star
0 siblings, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2017-01-20 7:31 UTC (permalink / raw)
To: Thomas Huth, edk2-devel@ml01.01.org; +Cc: Tian, Feng, Zeng, Star
Pushed the patch at cd5b2ae437553df0e491f926b8748bf88809e76a, thanks for the contribution.
Star
-----Original Message-----
From: Zeng, Star
Sent: Friday, January 20, 2017 2:03 PM
To: Thomas Huth <thuth@redhat.com>; edk2-devel@ml01.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements
No need to resend path, I can help push it with the typo fixed.
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Huth
Sent: Friday, January 20, 2017 1:58 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@ml01.01.org
Cc: Tian, Feng <feng.tian@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements
On 19.01.2017 11:22, Zeng, Star wrote:
> With the typo "explicitely" fixed in the commit log,
Oh, right, stupid me ;-) Could you maybe fix that when picking up the patch (since I can't commit this on my own)? Or shall I rather resend the patch?
Thanks,
Thomas
> Reviewed-by: Star Zeng <star.zeng@intel.com>
>
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Thomas Huth
> Sent: Thursday, January 19, 2017 6:16 PM
> To: edk2-devel@ml01.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return
> statements
>
> If the code eventually returns "Status" anyway, it does not make sense to explicitely return "Status" in case of an error, too.
> (this patch has been created with Coccinelle)
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 ---
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 ---
> MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 ---
> MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 ---
> 4 files changed, 12 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> index 51cff3c..ad6cdb1 100644
> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c
> @@ -1046,9 +1046,6 @@ NvmeControllerInit (
> // One for blocking I/O, one for non-blocking I/O.
> //
> Status = NvmeCreateIoSubmissionQueue (Private);
> - if (EFI_ERROR(Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> index 3f73194..9dbec10 100755
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
> @@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming,
> ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> index d6d3bdb..5a9e0b2 100644
> --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c
> @@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed (
>
> HsTiming = 1;
> Status = EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq);
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> diff --git
> a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> index 7ef141f..01bec19 100644
> --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
> @@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart (
> //
> Status = ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL);
> ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR
> (EFI_MAGENTA, EFI_BLACK));
> - if (EFI_ERROR (Status)) {
> - return Status;
> - }
>
> return Status;
> }
> --
> 1.8.3.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-20 7:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 10:16 [PATCH] MdeModulePkg: Remove superfluous return statements Thomas Huth
2017-01-19 10:22 ` Zeng, Star
2017-01-20 5:58 ` Thomas Huth
2017-01-20 6:02 ` Zeng, Star
2017-01-20 7:31 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox