From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 67B6481E9E for ; Thu, 19 Jan 2017 23:31:16 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 19 Jan 2017 23:31:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,257,1477983600"; d="scan'208";a="33067885" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 19 Jan 2017 23:31:15 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 23:31:15 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 23:31:15 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 15:31:13 +0800 From: "Zeng, Star" To: Thomas Huth , "edk2-devel@ml01.01.org" CC: "Tian, Feng" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg: Remove superfluous return statements Thread-Index: AQHScj0ayPvQNZ344kine0K2lHiD06E/lqHwgADDJgCAAIctUIAAGNEg Date: Fri, 20 Jan 2017 07:31:12 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8187C4@shsmsx102.ccr.corp.intel.com> References: <1484820964-30276-1-git-send-email-thuth@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B818407@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B81875F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B81875F@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Remove superfluous return statements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 07:31:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed the patch at cd5b2ae437553df0e491f926b8748bf88809e76a, thanks for th= e contribution. Star -----Original Message----- From: Zeng, Star=20 Sent: Friday, January 20, 2017 2:03 PM To: Thomas Huth ; edk2-devel@ml01.01.org Cc: Tian, Feng ; Zeng, Star Subject: RE: [edk2] [PATCH] MdeModulePkg: Remove superfluous return stateme= nts No need to resend path, I can help push it with the typo fixed. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thom= as Huth Sent: Friday, January 20, 2017 1:58 PM To: Zeng, Star ; edk2-devel@ml01.01.org Cc: Tian, Feng Subject: Re: [edk2] [PATCH] MdeModulePkg: Remove superfluous return stateme= nts On 19.01.2017 11:22, Zeng, Star wrote: > With the typo "explicitely" fixed in the commit log, Oh, right, stupid me ;-) Could you maybe fix that when picking up the patch= (since I can't commit this on my own)? Or shall I rather resend the patch? Thanks, Thomas > Reviewed-by: Star Zeng >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Thomas Huth > Sent: Thursday, January 19, 2017 6:16 PM > To: edk2-devel@ml01.01.org > Cc: Tian, Feng ; Zeng, Star > Subject: [edk2] [PATCH] MdeModulePkg: Remove superfluous return=20 > statements >=20 > If the code eventually returns "Status" anyway, it does not make sense to= explicitely return "Status" in case of an error, too. > (this patch has been created with Coccinelle) >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Thomas Huth > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 3 --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 3 --- > MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c | 3 --- > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 3 --- > 4 files changed, 12 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > index 51cff3c..ad6cdb1 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c > @@ -1046,9 +1046,6 @@ NvmeControllerInit ( > // One for blocking I/O, one for non-blocking I/O. > // > Status =3D NvmeCreateIoSubmissionQueue (Private); > - if (EFI_ERROR(Status)) { > - return Status; > - } > =20 > return Status; > } > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > index 3f73194..9dbec10 100755 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > @@ -783,9 +783,6 @@ EmmcSwitchToHighSpeed ( > =20 > HsTiming =3D 1; > Status =3D EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming,= =20 > ClockFreq); > - if (EFI_ERROR (Status)) { > - return Status; > - } > =20 > return Status; > } > diff --git a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > index d6d3bdb..5a9e0b2 100644 > --- a/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > +++ b/MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcHci.c > @@ -2520,9 +2520,6 @@ EmmcPeimSwitchToHighSpeed ( > =20 > HsTiming =3D 1; > Status =3D EmmcPeimSwitchClockFreq (Slot, Rca, HsTiming, ClockFreq); > - if (EFI_ERROR (Status)) { > - return Status; > - } > =20 > return Status; > } > diff --git > a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 7ef141f..01bec19 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -1465,9 +1465,6 @@ ConSplitterStdErrDriverBindingStart ( > // > Status =3D ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL)= ; > ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR=20 > (EFI_MAGENTA, EFI_BLACK)); > - if (EFI_ERROR (Status)) { > - return Status; > - } > =20 > return Status; > } > -- > 1.8.3.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >=20 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel