From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 477F581ECD for ; Sat, 21 Jan 2017 17:22:48 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 21 Jan 2017 17:22:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,266,1477983600"; d="scan'208";a="33721808" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 21 Jan 2017 17:22:47 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 21 Jan 2017 17:22:47 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 21 Jan 2017 17:22:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Sun, 22 Jan 2017 09:22:45 +0800 From: "Zeng, Star" To: "Zhang, Chao B" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [PATCH V2 2/3] SecurityPkg: Tcg2Dxe: Measure DBT into PCR[7] Thread-Index: AQHSchLeaanjAi0vMEaJlWOyKh0h5qFDt1TQ Date: Sun, 22 Jan 2017 01:22:45 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B818BCF@shsmsx102.ccr.corp.intel.com> References: <20170119051359.14044-1-chao.b.zhang@intel.com> <20170119051359.14044-2-chao.b.zhang@intel.com> In-Reply-To: <20170119051359.14044-2-chao.b.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V2 2/3] SecurityPkg: Tcg2Dxe: Measure DBT into PCR[7] X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2017 01:22:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chao, I have one minor comment. Please remember to add " ## SOMETIMES_CONSUMES ## Variable:L"dbt" " i= n Tcg2Dxe.inf. With the comment covered, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Zhang, Chao B=20 Sent: Thursday, January 19, 2017 1:14 PM To: edk2-devel@lists.01.org Cc: yao.jiewen@intel.com; Zeng, Star ; Yao, Jiewen ; Zhang, Chao B Subject: [PATCH V2 2/3] SecurityPkg: Tcg2Dxe: Measure DBT into PCR[7] Measure DBT into PCR[7] in initial measurement phase according to TCG PC Cl= ient PFP 00.37. http://www.trustedcomputinggroup.org/wp-content/uploads/PC-= ClientSpecific_Platform_Profile_for_TPM_2p0_Systems_v21.pdf Cc: Star Zeng Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tc= g2Dxe.c index 556ef33..3534fd1 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c @@ -1,7 +1,7 @@ /** @file This module implements Tcg2 Protocol. =20 -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
This pro= gram and the accompanying materials are licensed and made available under = the terms and conditions of the BSD License @@ -115,6 +115,7 @@ VARIABLE_TY= PE mVariableType[] =3D { {EFI_KEY_EXCHANGE_KEY_NAME, &gEfiGlobalVariableGuid}, {EFI_IMAGE_SECURITY_DATABASE, &gEfiImageSecurityDatabaseGuid}, {EFI_IMAGE_SECURITY_DATABASE1, &gEfiImageSecurityDatabaseGuid}, + {EFI_IMAGE_SECURITY_DATABASE2, &gEfiImageSecurityDatabaseGuid}, }; =20 EFI_HANDLE mImageHandle; -- 1.9.5.msysgit.1