Re: [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1

["Zeng, Star" <star.zeng@intel.com>]

Yes, good catch.

Thanks,
Star
-----Original Message-----
From: Gao, Liming 
Sent: Tuesday, January 24, 2017 3:25 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1

Star:
  Please fix the incorrect character in comments. With this change, I add my Reviewed-by: Liming Gao <liming.gao@intel.com>

+/// 00h  C 3Fh: MCTP Host Interfaces

Thanks
Liming
>-----Original Message-----
>From: Zeng, Star
>Sent: Sunday, January 22, 2017 4:18 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming 
><liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH 1/3] MdePkg: Add definitions for SMBIOS spec 3.1.1
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=349
>
>This patch is to add definitions for below items.
>Processor Information (Type 4):
>- add socket SP3r2
>- add AMD Zen Processor Family
>Management Controller Host Interface (Type 42):
>- include Host Interface Type and Protocol Identifier enumerations
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> MdePkg/Include/IndustryStandard/SmBios.h | 25
>+++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
>diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
>b/MdePkg/Include/IndustryStandard/SmBios.h
>index f5c29bcbd0c8..6a8fa1b39d17 100644
>--- a/MdePkg/Include/IndustryStandard/SmBios.h
>+++ b/MdePkg/Include/IndustryStandard/SmBios.h
>@@ -611,6 +611,7 @@ typedef enum {
>   ProcessorFamilyAmdOpteronX2000Series  = 0x68,
>   ProcessorFamilyAmdOpteronASeries      = 0x69,
>   ProcessorFamilyAmdOpteronX3000Series  = 0x6A,
>+  ProcessorFamilyAmdZen                 = 0x6B,
>   ProcessorFamilyHobbit                 = 0x70,
>   ProcessorFamilyCrusoeTM5000           = 0x78,
>   ProcessorFamilyCrusoeTM3000           = 0x79,
>@@ -804,7 +805,8 @@ typedef enum {
>   ProcessorUpgradeSocketBGA1440   = 0x34,
>   ProcessorUpgradeSocketBGA1515   = 0x35,
>   ProcessorUpgradeSocketLGA3647_1 = 0x36,
>-  ProcessorUpgradeSocketSP3       = 0x37
>+  ProcessorUpgradeSocketSP3       = 0x37,
>+  ProcessorUpgradeSocketSP3r2     = 0x38
> } PROCESSOR_UPGRADE;
>
> ///
>@@ -2386,6 +2388,25 @@ typedef struct {  } SMBIOS_TABLE_TYPE41;
>
> ///
>+/// Management Controller Host Interface - Interface Types.
>+/// 00h  C 3Fh: MCTP Host Interfaces
>+///
>+typedef enum{
>+  MCHostInterfaceTypeNetworkHostInterface       = 0x40,
>+  MCHostInterfaceTypeOemDefined                 = 0xF0
>+} MC_HOST_INTERFACE_TYPE;
>+
>+///
>+/// Management Controller Host Interface - Protocol Types.
>+///
>+typedef enum{
>+  MCHostInterfaceProtocolTypeIPMI               = 0x02,
>+  MCHostInterfaceProtocolTypeMCTP               = 0x03,
>+  MCHostInterfaceProtocolTypeRedfishOverIP      = 0x04,
>+  MCHostInterfaceProtocolTypeOemDefined         = 0xF0
>+} MC_HOST_INTERFACE_PROTOCOL_TYPE;
>+
>+///
> /// Management Controller Host Interface (Type 42).
> ///
> /// The information in this structure defines the attributes of a 
>Management @@ -2404,7 +2425,7 @@ typedef struct {  ///  typedef struct 
>{
>   SMBIOS_STRUCTURE                  Hdr;
>-  UINT8                             InterfaceType;
>+  UINT8                             InterfaceType;          ///< The enumeration value from
>MC_HOST_INTERFACE_TYPE
>   UINT8                             MCHostInterfaceData[1]; ///< This field has a minimum
>of four bytes
> } SMBIOS_TABLE_TYPE42;
>
>--
>2.7.0.windows.1