* [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic
@ 2017-02-09 7:04 Liming Gao
2017-02-09 7:05 ` Tian, Feng
2017-02-09 7:05 ` Zeng, Star
0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2017-02-09 7:04 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Feng Tian
Cc: Star Zeng <star.zeng@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index d3a5cda..26b71f1 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -1,7 +1,7 @@
/** @file
SMM IPL that produces SMM related runtime protocols and load the SMM Core into SMRAM
- Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available
under the terms and conditions of the BSD License which accompanies this
distribution. The full text of the license may be found at
@@ -521,7 +521,7 @@ SmmCommunicationCommunicate (
gSmmCorePrivate->InSmm = TRUE;
//
- // Already in SMM and before SetVirtualAddressMap(), so call SmiManage() directly.
+ // Before SetVirtualAddressMap(), we are in SMM or SMRAM is open and unlocked, call SmiManage() directly.
//
CommunicateHeader = (EFI_SMM_COMMUNICATE_HEADER *)CommBuffer;
*CommSize -= OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data);
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic
2017-02-09 7:04 [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic Liming Gao
@ 2017-02-09 7:05 ` Tian, Feng
2017-02-09 7:05 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Tian, Feng @ 2017-02-09 7:05 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Zeng, Star, Tian, Feng
Reviewed-by: Feng Tian <feng.tian@intel.com>
Thanks
Feng
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, February 9, 2017 3:05 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic
Cc: Star Zeng <star.zeng@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index d3a5cda..26b71f1 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -1,7 +1,7 @@
/** @file
SMM IPL that produces SMM related runtime protocols and load the SMM Core into SMRAM
- Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available
under the terms and conditions of the BSD License which accompanies this
distribution. The full text of the license may be found at
@@ -521,7 +521,7 @@ SmmCommunicationCommunicate (
gSmmCorePrivate->InSmm = TRUE;
//
- // Already in SMM and before SetVirtualAddressMap(), so call SmiManage() directly.
+ // Before SetVirtualAddressMap(), we are in SMM or SMRAM is open and unlocked, call SmiManage() directly.
//
CommunicateHeader = (EFI_SMM_COMMUNICATE_HEADER *)CommBuffer;
*CommSize -= OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data);
--
2.8.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic
2017-02-09 7:04 [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic Liming Gao
2017-02-09 7:05 ` Tian, Feng
@ 2017-02-09 7:05 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2017-02-09 7:05 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, February 9, 2017 3:05 PM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic
Cc: Star Zeng <star.zeng@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
index d3a5cda..26b71f1 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
@@ -1,7 +1,7 @@
/** @file
SMM IPL that produces SMM related runtime protocols and load the SMM Core into SMRAM
- Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials are licensed and made available
under the terms and conditions of the BSD License which accompanies this
distribution. The full text of the license may be found at
@@ -521,7 +521,7 @@ SmmCommunicationCommunicate (
gSmmCorePrivate->InSmm = TRUE;
//
- // Already in SMM and before SetVirtualAddressMap(), so call SmiManage() directly.
+ // Before SetVirtualAddressMap(), we are in SMM or SMRAM is open and unlocked, call SmiManage() directly.
//
CommunicateHeader = (EFI_SMM_COMMUNICATE_HEADER *)CommBuffer;
*CommSize -= OFFSET_OF (EFI_SMM_COMMUNICATE_HEADER, Data);
--
2.8.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-09 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 7:04 [PATCH v2] MdeModulePkg PiSmmIpl: Update SmmCommunication comments to match code logic Liming Gao
2017-02-09 7:05 ` Tian, Feng
2017-02-09 7:05 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox