From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 471B981F5B for ; Sun, 26 Feb 2017 18:20:30 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 26 Feb 2017 18:20:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,211,1484035200"; d="scan'208";a="62400098" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 26 Feb 2017 18:20:29 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 26 Feb 2017 18:20:29 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 26 Feb 2017 18:20:29 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Mon, 27 Feb 2017 10:20:25 +0800 From: "Zeng, Star" To: Leo Duran , "edk2-devel@ml01.01.org" CC: "Tian, Feng" , Laszlo Ersek , Brijesh Singh , "Zeng, Star" Thread-Topic: [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask Thread-Index: AQHSkFfWOrfSNOoRr0az/d8u7iLpGKF8HSeA Date: Mon, 27 Feb 2017 02:20:25 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B82C0D8@shsmsx102.ccr.corp.intel.com> References: <1488130987-2544-1-git-send-email-leo.duran@amd.com> <1488130987-2544-2-git-send-email-leo.duran@amd.com> In-Reply-To: <1488130987-2544-2-git-send-email-leo.duran@amd.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 02:20:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We saw you defined 4K/2M/1G in previous patch series, #define PAGING_4K_ADDRESS_MASK_64 0x000FFFFFFFFFF000ull #define PAGING_2M_ADDRESS_MASK_64 0x000FFFFFFFE00000ull #define PAGING_1G_ADDRESS_MASK_64 0x000FFFFFC0000000ull But only 1G mask is defined and used in this patch series, is that on purpo= se? #define PAGING_1G_ADDRESS_MASK_64 0x000FFFFFC0000000ull That means PcdPteMemoryEncryptionAddressOrMask will be just valid as 1G ali= gned, right? Thanks, Star -----Original Message----- From: Leo Duran [mailto:leo.duran@amd.com]=20 Sent: Monday, February 27, 2017 1:43 AM To: edk2-devel@ml01.01.org Cc: Leo Duran ; Tian, Feng ; Zeng, = Star ; Laszlo Ersek ; Brijesh Singh= Subject: [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddress= OrMask This PCD holds the address mask for page table entries when memory encrypti= on is enabled on AMD processors supporting the Secure Encrypted Virtualizat= ion (SEV) feature. Cc: Feng Tian Cc: Star Zeng Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brijesh Singh Signed-off-by: Leo Duran Reviewed-by: Star Zeng --- MdeModulePkg/MdeModulePkg.dec | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec = index 426634f..f45ca84 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -6,6 +6,8 @@ # Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.
= # Copyright (c) 2016, Linaro Ltd. All rights reserved.
# (C) Copyright= 2016 Hewlett Packard Enterprise Development LP
+# Copyright (c) 2017, AMD Incorporated. All rights reserved.
# # This program and the accompanying materials are licensed and made availa= ble under # the terms and conditions of the BSD License that accompanies t= his distribution. # The full text of the license may be found at @@ -1702,6 +1704,12 @@ # @Prompt A list of system FMP ImageTypeId GUIDs gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGuid|{0x0}|= VOID*|0x30001046 =20 + ## This PCD holds the address mask for page table entries when memory=20 + encryption is # enabled on AMD processors supporting the Secure Encrypt= ed Virtualization (SEV) feature. + # This mask should be applied when creating 1:1 virtual to physical map= ping tables. + # + =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0 + |UINT64|0x30001047 + [PcdsPatchableInModule] ## Specify memory size with page number for PEI code when # Loading Module at Fixed Address feature is enabled. -- 2.7.4