public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2] MdeModulePkg/PeiCore: honour minimal runtime allocation granularity
Date: Fri, 3 Mar 2017 09:17:07 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B82E90B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu8RivdoMRe3eHnUnBFzmaRvXj3m1FAvu9xxy1Zng3NTWg@mail.gmail.com>

According to PI Spec.
"Note:MemoryBaseAddress and MemoryLength must each have 4-KiB granularity to meet the page size requirements of UEFI."

Memory allocation HOB covers full pages only.

Thanks,
Star

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Friday, March 3, 2017 5:12 PM
To: Gao, Liming <liming.gao@intel.com>
Cc: edk2-devel@lists.01.org; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] [PATCH v2] MdeModulePkg/PeiCore: honour minimal runtime allocation granularity

On 3 March 2017 at 09:05, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:
>   First is to make FreeMemoryTop at the expected alignment. If original FreeMemoryTop is not aligned, it will be adjusted to be align. Then, there is one memory hole that can't be used any more. I suggest to create BuildMemoryAllocationHob() with EfiConventionalMemory to describe this hole.

OK. But the original code may already result in some non-page aligned memory to be discarded, should that be described as well? Or should the EfiConventionalMemory HOB cover full pages only?

Now, MdePkg\Library\PeiMemoryAllocationLib AllocateAlignedPages() uses this way to describe extra memory space.

Thanks,
Ard.

      reply	other threads:[~2017-03-03  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  8:37 [PATCH v2] MdeModulePkg/PeiCore: honour minimal runtime allocation granularity Ard Biesheuvel
2017-03-03  9:05 ` Gao, Liming
2017-03-03  9:12   ` Ard Biesheuvel
2017-03-03  9:17     ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B82E90B@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox