From: "Zeng, Star" <star.zeng@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
Leo Duran <leo.duran@amd.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [patch] MdeModulePkg: Add PROMPT&HELP string of pcd to UNI file
Date: Tue, 7 Mar 2017 02:09:16 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B82F503@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1488516286-44788-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Friday, March 3, 2017 12:45 PM
To: edk2-devel@lists.01.org
Cc: Brijesh Singh <brijesh.singh@amd.com>; Leo Duran <leo.duran@amd.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zeng, Star <star.zeng@intel.com>
Subject: [patch] MdeModulePkg: Add PROMPT&HELP string of pcd to UNI file
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Leo Duran <leo.duran@amd.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 2 +-
MdeModulePkg/MdeModulePkg.uni | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 356b3e1..626e479 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1737,11 +1737,11 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGuid|{0x0}|VOID*|0x30001046
## This PCD holds the address mask for page table entries when memory encryption is
# enabled on AMD processors supporting the Secure Encrypted Virtualization (SEV) feature.
# This mask should be applied when creating 1:1 virtual to physical mapping tables.
- #
+ # @Prompt The address mask when memory encryption is enabled.
gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0|UINT64|0x30001047
[PcdsPatchableInModule]
## Specify memory size with page number for PEI code when
# Loading Module at Fixed Address feature is enabled.
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index ff0d697..d6015de 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1087,5 +1087,43 @@
"The code section becomes read-only, and the data section becomes non-executable.\n"
"If a bit is clear, the image will not be protected.<BR><BR>\n"
"BIT0 - Image from unknown device. <BR>\n"
"BIT1 - Image from firmware volume.<BR>"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdDxeNxMemoryProtectionPolicy_PROMPT #language en-US "Set DXE memory protection policy."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdDxeNxMemoryProtectionPolicy_HELP #language en-US "Set DXE memory protection policy. The policy is bitwise.\n"
+ "If a bit is set, memory regions of the associated type will be mapped\n"
+ "non-executable.<BR><BR>\n"
+ "\n"
+ "Below is bit mask for this PCD: (Order is same as UEFI spec)<BR>\n"
+ "EfiReservedMemoryType 0x0001<BR>\n"
+ "EfiLoaderCode 0x0002<BR>\n"
+ "EfiLoaderData 0x0004<BR>\n"
+ "EfiBootServicesCode 0x0008<BR>\n"
+ "EfiBootServicesData 0x0010<BR>\n"
+ "EfiRuntimeServicesCode 0x0020<BR>\n"
+ "EfiRuntimeServicesData 0x0040<BR>\n"
+ "EfiConventionalMemory 0x0080<BR>\n"
+ "EfiUnusableMemory 0x0100<BR>\n"
+ "EfiACPIReclaimMemory 0x0200<BR>\n"
+ "EfiACPIMemoryNVS 0x0400<BR>\n"
+ "EfiMemoryMappedIO 0x0800<BR>\n"
+ "EfiMemoryMappedIOPortSpace 0x1000<BR>\n"
+ "EfiPalCode 0x2000<BR>\n"
+ "EfiPersistentMemory 0x4000<BR>\n"
+ "OEM Reserved 0x4000000000000000<BR>\n"
+ "OS Reserved 0x8000000000000000<BR>\n"
+ "\n"
+ "NOTE: User must NOT set NX protection for EfiLoaderCode / EfiBootServicesCode / EfiRuntimeServicesCode. <BR>\n"
+ "User MUST set the same NX protection for EfiBootServicesData and EfiConventionalMemory. <BR>\n"
+ "\n"
+ "e.g. 0x7FD5 can be used for all memory except Code. <BR>\n"
+ "e.g. 0x7BD4 can be used for all memory except Code and ACPINVS/Reserved. <BR>\n"
+ ""
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPteMemoryEncryptionAddressOrMask_PROMPT #language en-US "The address mask when memory encryption is enabled."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPteMemoryEncryptionAddressOrMask_HELP #language en-US "This PCD holds the address mask for page table entries when memory encryption is\n"
+ "enabled on AMD processors supporting the Secure Encrypted Virtualization (SEV) feature.\n"
+ "This mask should be applied when creating 1:1 virtual to physical mapping tables."
+
--
1.9.5.msysgit.1
next prev parent reply other threads:[~2017-03-07 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 4:44 [patch] MdeModulePkg: Add PROMPT&HELP string of pcd to UNI file Dandan Bi
2017-03-03 4:44 ` [patch] MdeModulePkg/DxeCore: Fix coding style issues Dandan Bi
2017-03-07 2:10 ` Zeng, Star
2017-03-07 13:49 ` Zeng, Star
2017-03-07 2:09 ` Zeng, Star [this message]
2017-03-07 13:48 ` [patch] MdeModulePkg: Add PROMPT&HELP string of pcd to UNI file Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B82F503@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox