From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EE862803D1 for ; Mon, 20 Mar 2017 02:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490003873; x=1521539873; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=67y1haBOGvJW2lI8i7j2C5W77j4Fa//VaTCcePFsWIk=; b=UZPRGeIrOF9Ovr0G4GjazPRE3bnMZcfe+NstA9ADyGuf71UMOISmlacA Sqh8xHm4h1Po/PlCcXgI1lo+Nk33DA==; Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2017 02:57:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,193,1486454400"; d="scan'208";a="238207113" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 20 Mar 2017 02:57:53 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Mar 2017 02:57:53 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Mon, 20 Mar 2017 17:57:51 +0800 From: "Zeng, Star" To: Laszlo Ersek , edk2-devel-01 CC: "Wu, Hao A" , "Tian, Feng" , Leif Lindholm , Ard Biesheuvel , "Zeng, Star" Thread-Topic: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages Thread-Index: AQHSn1+9w7OyBAKAzEao+BFn2JBHJaGdAOCA///38wCAAIk2EA== Date: Mon, 20 Mar 2017 09:57:50 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8360ED@shsmsx102.ccr.corp.intel.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-4-lersek@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B835B1D@shsmsx102.ccr.corp.intel.com> <322be6fe-5c1e-fc2d-c92f-3770ba32cdbf@redhat.com> In-Reply-To: <322be6fe-5c1e-fc2d-c92f-3770ba32cdbf@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 09:57:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, please. :) Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Monday, March 20, 2017 5:46 PM To: Zeng, Star ; edk2-devel-01 Cc: Wu, Hao A ; Tian, Feng ; Leif = Lindholm ; Ard Biesheuvel Subject: Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string = literal catenation in info messages On 03/20/17 03:16, Zeng, Star wrote: > I am ok with this patch. Thanks -- should I add an R-b or A-b in your name? Thanks Laszlo >=20 > Feng and Hao, do you have any comments? >=20 > Thanks, > Star > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com]=20 > Sent: Saturday, March 18, 2017 4:47 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star > Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal c= atenation in info messages >=20 > RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback functio= n. If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, t= hen informational messages are logged, and the RAM disks are not published = to the (nonexistent) NFIT table. >=20 > The logic is fine, but the info messages are not concatenated correctly f= rom multiple string literals -- the second parts are passed as (unused) arg= uments to DEBUG(). Fix the typos. >=20 > Cc: Ard Biesheuvel > Cc: Feng Tian > Cc: Hao Wu > Cc: Leif Lindholm > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c b/Mde= ModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > index d1dd13a8197b..b2bafc58bb71 100644 > --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > return; > @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > mAcpiTableProtocol =3D NULL; > -- > 2.9.3 >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >=20 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel