public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
@ 2017-03-23  2:44 Guoheyi
  2017-03-23  2:51 ` Zeng, Star
  2017-03-23  5:12 ` Fu, Siyuan
  0 siblings, 2 replies; 5+ messages in thread
From: Guoheyi @ 2017-03-23  2:44 UTC (permalink / raw)
  To: edk2-devel@lists.01.org; +Cc: Feng Tian, Star Zeng

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
  2017-03-23  2:44 [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Guoheyi
@ 2017-03-23  2:51 ` Zeng, Star
  2017-03-23  5:12 ` Fu, Siyuan
  1 sibling, 0 replies; 5+ messages in thread
From: Zeng, Star @ 2017-03-23  2:51 UTC (permalink / raw)
  To: Fu, Siyuan, Guoheyi, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star

Siyuan,

Could you help confirm it?

Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoheyi
Sent: Thursday, March 23, 2017 10:45 AM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
  2017-03-23  2:44 [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Guoheyi
  2017-03-23  2:51 ` Zeng, Star
@ 2017-03-23  5:12 ` Fu, Siyuan
  2017-03-23  5:38   ` 答复: " Guoheyi
  1 sibling, 1 reply; 5+ messages in thread
From: Fu, Siyuan @ 2017-03-23  5:12 UTC (permalink / raw)
  To: Guoheyi, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star

Hi, Gary

I think this line is just a redundant code, it’s obviously useless, we can remove it.

Best Regards,
Siyuan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoheyi
Sent: 2017年3月23日 10:45
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* 答复: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
  2017-03-23  5:12 ` Fu, Siyuan
@ 2017-03-23  5:38   ` Guoheyi
  2017-03-23  5:41     ` Fu, Siyuan
  0 siblings, 1 reply; 5+ messages in thread
From: Guoheyi @ 2017-03-23  5:38 UTC (permalink / raw)
  To: Fu, Siyuan, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star

Hi Siyuan,

Our static scan tool always alarms on this code, so it will be great if you can help remove such redundant code.

Thanks.

Gary (Heyi Guo)

-----邮件原件-----
发件人: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] 代表 Fu, Siyuan
发送时间: 2017年3月23日 13:13
收件人: Guoheyi; edk2-devel@lists.01.org
抄送: Tian, Feng; Zeng, Star
主题: Re: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi, Gary

I think this line is just a redundant code, it’s obviously useless, we can remove it.

Best Regards,
Siyuan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoheyi
Sent: 2017年3月23日 10:45
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?
  2017-03-23  5:38   ` 答复: " Guoheyi
@ 2017-03-23  5:41     ` Fu, Siyuan
  0 siblings, 0 replies; 5+ messages in thread
From: Fu, Siyuan @ 2017-03-23  5:41 UTC (permalink / raw)
  To: Guoheyi, edk2-devel@lists.01.org; +Cc: Tian, Feng, Zeng, Star

Yes, please file a new tracker in https://tianocore.acgmultimedia.com/

Thanks,
Siyuan

-----Original Message-----
From: Guoheyi [mailto:guoheyi@huawei.com] 
Sent: 2017年3月23日 13:39
To: Fu, Siyuan <siyuan.fu@intel.com>; edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: 答复: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi Siyuan,

Our static scan tool always alarms on this code, so it will be great if you can help remove such redundant code.

Thanks.

Gary (Heyi Guo)

-----邮件原件-----
发件人: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] 代表 Fu, Siyuan
发送时间: 2017年3月23日 13:13
收件人: Guoheyi; edk2-devel@lists.01.org
抄送: Tian, Feng; Zeng, Star
主题: Re: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi, Gary

I think this line is just a redundant code, it’s obviously useless, we can remove it.

Best Regards,
Siyuan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoheyi
Sent: 2017年3月23日 10:45
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c?

Hi folks,

In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporary variable Packet is set but not used, nor it is referred by any event. Is it a bug or just something useless?

666     if (Packet == NULL) {
667       Packet = IpSecWrap->Packet;           // Packet is set here, but not used any more.
668       gBS->SignalEvent (RecycleEvent);
669       FreePool (IpSecWrap);
670       Status = EFI_OUT_OF_RESOURCES;
671       goto ON_EXIT;                        // function will return on ON_EXIT
672     }


Please advise.

Thanks and regards,

Gary (Heyi Guo)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-23  5:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23  2:44 [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Guoheyi
2017-03-23  2:51 ` Zeng, Star
2017-03-23  5:12 ` Fu, Siyuan
2017-03-23  5:38   ` 答复: " Guoheyi
2017-03-23  5:41     ` Fu, Siyuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox