From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4A78980468 for ; Wed, 22 Mar 2017 19:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490237485; x=1521773485; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZyhNMfNIcWYbuWB3E4pGgr7h5u2JgWscRspPipwuLn4=; b=a394UOjRMPzmiLmxdfOzF7H6WdQMpLfjuZyTf3YLdnfcv19vZ55xhTEm tvhnNZiQf/dT2pmAwpIwfn1SE1qvVQ==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 19:51:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,207,1486454400"; d="scan'208";a="947267327" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 22 Mar 2017 19:51:24 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 19:51:24 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 19:51:24 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 10:51:22 +0800 From: "Zeng, Star" To: "Fu, Siyuan" , Guoheyi , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Zeng, Star" Thread-Topic: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Thread-Index: AdKjf2SzCjN4RAAEQhKLq7Zro+AaVgAAOVyw Date: Thu, 23 Mar 2017 02:51:21 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8378B4@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 02:51:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Siyuan, Could you help confirm it? Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Guoh= eyi Sent: Thursday, March 23, 2017 10:45 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [edk2] [MdeModulePkg/Ip4Dxe] Is it a bug in Ip4Input.c? Hi folks, In MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Inpu.c, line #666~672, temporar= y variable Packet is set but not used, nor it is referred by any event. Is = it a bug or just something useless? 666 if (Packet =3D=3D NULL) { 667 Packet =3D IpSecWrap->Packet; // Packet is set here, bu= t not used any more. 668 gBS->SignalEvent (RecycleEvent); 669 FreePool (IpSecWrap); 670 Status =3D EFI_OUT_OF_RESOURCES; 671 goto ON_EXIT; // function will return on O= N_EXIT 672 } Please advise. Thanks and regards, Gary (Heyi Guo) _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel