Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

["Zeng, Star" <star.zeng@intel.com>]

With that, you can have my Reviewed-by: Star Zeng <star.zeng@intel.com>

Thanks,
Star
-----Original Message-----
From: Gao, Liming 
Sent: Thursday, April 6, 2017 4:40 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option

Good suggestion. I will update commit log. 

>-----Original Message-----
>From: Zeng, Star
>Sent: Thursday, April 06, 2017 4:22 PM
>To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>
>Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove 
>GCC -fno-builtin option
>
>How about to indicate the SHA-1:
>90defe7198a42b3157ae5d9b93714f891cf06e57 in the commit log like below?
>
>GCC -fno-builtin option is added into tools_def.template at 
>90defe7198a42b3157ae5d9b93714f891cf06e57.
>So, there is no need to set it in module INF file.
>
>Thanks,
>Star
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
>Liming Gao
>Sent: Thursday, April 6, 2017 4:15 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC - 
>fno-builtin option
>
>GCC -fno-builtin option is added into tools_def.template. So, there is 
>no need to set it in module INF file.
>
>Cc: Star Zeng <star.zeng@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Liming Gao <liming.gao@intel.com>
>---
> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
>| 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git
>a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>index cfe42a6..d4d9a83 100644
>---
>a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in
>f
>+++
>b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i
>+++ nf
>@@ -81,7 +81,6 @@
>   MSFT:DEBUG_*_IPF_CC_FLAGS    == /nologo /c /WX /GS- /W4 /EHs-c- /GR-
>/Gy /Os /FIAutoGen.h /QIPF_fr32 /Zi /X
>   MSFT:RELEASE_*_IPF_CC_FLAGS  == /nologo /c /WX /GS- /W4 /EHs-c- /GR- 
>/Gy /Os /FIAutoGen.h /QIPF_fr32 /X
>   INTEL:*_*_*_CC_FLAGS         =  /Oi-
>-  GCC:*_*_*_CC_FLAGS           =  -fno-builtin
>
>   # Oniguruma: potentially uninitialized local variable used
>   MSFT:*_*_*_CC_FLAGS = /wd4701
>--
>2.8.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel