From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E163D21942329 for ; Thu, 6 Apr 2017 01:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491468104; x=1523004104; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gB6nV4V56wB//WzkgkAShFFUasUtwp5NEvVRpI8LWuY=; b=Zf0RCQK6A3DkVILhNoqRWQ8NuroRjFjdVPRr/PtlFs18yEzNol7EMIFr DEAikRR8SJAM/jujYVM96dNEZS+Vbg==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 01:41:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,283,1488873600"; d="scan'208";a="1131741417" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 06 Apr 2017 01:41:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 6 Apr 2017 01:41:44 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Thu, 6 Apr 2017 16:41:42 +0800 From: "Zeng, Star" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option Thread-Index: AQHSrq36z/h5QCVJq0WNpC+RibCjFqG3/3sw//9/wgCAAIZ8kA== Date: Thu, 6 Apr 2017 08:41:41 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B877137@shsmsx102.ccr.corp.intel.com> References: <1491466509-10944-1-git-send-email-liming.gao@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8770F8@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D71A187@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D71A187@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -fno-builtin option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 08:41:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With that, you can have my Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Gao, Liming=20 Sent: Thursday, April 6, 2017 4:40 PM To: Zeng, Star ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -= fno-builtin option Good suggestion. I will update commit log.=20 >-----Original Message----- >From: Zeng, Star >Sent: Thursday, April 06, 2017 4:22 PM >To: Gao, Liming ; edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: RE: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove=20 >GCC -fno-builtin option > >How about to indicate the SHA-1: >90defe7198a42b3157ae5d9b93714f891cf06e57 in the commit log like below? > >GCC -fno-builtin option is added into tools_def.template at=20 >90defe7198a42b3157ae5d9b93714f891cf06e57. >So, there is no need to set it in module INF file. > >Thanks, >Star >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 >Liming Gao >Sent: Thursday, April 6, 2017 4:15 PM >To: edk2-devel@lists.01.org >Cc: Zeng, Star >Subject: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove GCC -=20 >fno-builtin option > >GCC -fno-builtin option is added into tools_def.template. So, there is=20 >no need to set it in module INF file. > >Cc: Star Zeng >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Liming Gao >--- > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >| 1 - > 1 file changed, 1 deletion(-) > >diff --git >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >index cfe42a6..d4d9a83 100644 >--- >a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.in >f >+++ >b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i >+++ nf >@@ -81,7 +81,6 @@ > MSFT:DEBUG_*_IPF_CC_FLAGS =3D=3D /nologo /c /WX /GS- /W4 /EHs-c- /GR= - >/Gy /Os /FIAutoGen.h /QIPF_fr32 /Zi /X > MSFT:RELEASE_*_IPF_CC_FLAGS =3D=3D /nologo /c /WX /GS- /W4 /EHs-c- /GR= -=20 >/Gy /Os /FIAutoGen.h /QIPF_fr32 /X > INTEL:*_*_*_CC_FLAGS =3D /Oi- >- GCC:*_*_*_CC_FLAGS =3D -fno-builtin > > # Oniguruma: potentially uninitialized local variable used > MSFT:*_*_*_CC_FLAGS =3D /wd4701 >-- >2.8.0.windows.1 > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel