From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6CEB21954084 for ; Mon, 24 Apr 2017 17:53:19 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2017 17:53:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,247,1488873600"; d="scan'208";a="78401009" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 24 Apr 2017 17:53:18 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 24 Apr 2017 17:53:17 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 24 Apr 2017 17:53:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Tue, 25 Apr 2017 08:53:15 +0800 From: "Zeng, Star" To: Jeff Westfahl , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Carsey, Jaben" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal Thread-Index: AQHSuuXdyoiBmlxigU+vOHMZPrPP4qHRW3VQgAPrSCA= Date: Tue, 25 Apr 2017 00:53:14 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B87E038@shsmsx102.ccr.corp.intel.com> References: <0C09AFA07DD0434D9E2A0C6AEB0483103B87D584@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B87D584@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 00:53:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch has been pushed at fed709deb444084594c2e11a1886819fa54afc00. Thanks, Star -----Original Message----- From: Zeng, Star=20 Sent: Saturday, April 22, 2017 9:03 PM To: Jeff Westfahl ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben ;= Zeng, Star Subject: RE: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segmen= t in hexadecimal It is ok to me. Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff= Westfahl Sent: Saturday, April 22, 2017 5:25 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Carsey, Jaben Subject: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in= hexadecimal The SMBIOS Type 0 BIOS segment field is currently displayed in decimal. Since this field is likely to have a value like 0xE800 or 0xF000, using hex= adecimal seems like a better choice. Cc: Ruiyu Ni Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 50d15ef..038f111 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -316,7 +316,7 @@ SmbiosPrintStructure ( case 0: PRINT_PENDING_STRING (Struct, Type0, Vendor); PRINT_PENDING_STRING (Struct, Type0, BiosVersion); - PRINT_STRUCT_VALUE (Struct, Type0, BiosSegment); + PRINT_STRUCT_VALUE_H (Struct, Type0, BiosSegment); PRINT_PENDING_STRING (Struct, Type0, BiosReleaseDate); ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BIOS= _SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); =20 -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel