From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3ECEF21A16E4A for ; Mon, 15 May 2017 22:41:48 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 15 May 2017 22:41:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,347,1491289200"; d="scan'208";a="1169686394" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 15 May 2017 22:41:46 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 May 2017 22:41:45 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 May 2017 22:41:45 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Tue, 16 May 2017 13:41:34 +0800 From: "Zeng, Star" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in UfsPassThruGetTargetLun() Thread-Index: AQHSzgYr9mbWeGJ4r0CdgItmYQCqdaH2ccYQ Date: Tue, 16 May 2017 05:41:33 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8B4F2A@shsmsx102.ccr.corp.intel.com> References: <20170516053439.18592-1-hao.a.wu@intel.com> In-Reply-To: <20170516053439.18592-1-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in UfsPassThruGetTargetLun() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 05:41:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Wu, Hao A=20 Sent: Tuesday, May 16, 2017 1:35 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A ; Zeng, Star Subject: [PATCH] MdeModulePkg/UfsPassThruDxe: Fix typo in UfsPassThruGetTar= getLun() For function UfsPassThruGetTargetLun(), the length of the input device node= specified by 'DevicePath' should be compared with the size of 'UFS_DEVICE_= PATH' rather than the size of 'SCSI_DEVICE_PATH'. Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c b/MdeModuleP= kg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c index 68a44367b5..e27f4fbab1 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c @@ -479,10 +479,10 @@ UfsPassThruGetTargetLun ( } =20 // - // Check whether the DevicePath belongs to SCSI_DEVICE_PATH + // Check whether the DevicePath belongs to UFS_DEVICE_PATH // if ((DevicePath->Type !=3D MESSAGING_DEVICE_PATH) || (DevicePath->SubTyp= e !=3D MSG_UFS_DP) || - (DevicePathNodeLength(DevicePath) !=3D sizeof(SCSI_DEVICE_PATH))) { + (DevicePathNodeLength(DevicePath) !=3D sizeof(UFS_DEVICE_PATH))) { return EFI_UNSUPPORTED; } =20 -- 2.12.0.windows.1