From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 73AC121A134BC for ; Sun, 21 May 2017 19:11:37 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2017 19:11:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="1172504706" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 21 May 2017 19:11:37 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 May 2017 19:11:36 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 May 2017 19:11:36 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Mon, 22 May 2017 10:11:34 +0800 From: "Zeng, Star" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , Andrew Fish , "Zeng, Star" Thread-Topic: [Patch V2] MdeModulePkg/LogoDxe: Return error if HII Package not present Thread-Index: AQHS0Ly7nOCV7Nu7dEeuULxQikUnWqH/n75g Date: Mon, 22 May 2017 02:11:33 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8C4431@shsmsx102.ccr.corp.intel.com> References: <1495211211-23596-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1495211211-23596-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch V2] MdeModulePkg/LogoDxe: Return error if HII Package not present X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 02:11:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable There is a typo "messahe" in the commit log. With the typo fixed, Reviewed-by: Star Zeng Thanks, Star -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, May 20, 2017 12:27 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; And= rew Fish Subject: [Patch V2] MdeModulePkg/LogoDxe: Return error if HII Package not p= resent https://bugzilla.tianocore.org/show_bug.cgi?id=3D554 Update LogoDxe module to print a DEBUG() messahe and exit with an error ins= tead of ASSERT_EFI_ERROR() if the HII Image Package with the logo image is = not present. If a tool chain does not support generation of PE/COFF resource sections, t= hen this module can not produce the logo from an HII Image Package. XCODE5= is an example of a tool chain that does not currently support generation o= f PE/COFF resource sections. Cc: Star Zeng Cc: Eric Dong Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- MdeModulePkg/Logo/Logo.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c index 313d= d4a..1789ad9 100644 --- a/MdeModulePkg/Logo/Logo.c +++ b/MdeModulePkg/Logo/Logo.c @@ -1,7 +1,7 @@ /** @file Logo DXE Driver, install Edkii Platform Logo protocol. =20 -Copyright (c) 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -133,7 +13= 3,10 @@ InitializeLogo ( NULL, EFI_OPEN_PROTOCOL_GET_PROTOCOL ); - ASSERT_EFI_ERROR (Status); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "HII Image Package with logo not found in PE/COFF= resource section\n")); + return Status; + } =20 // // Publish HII package list to HII Database. -- 2.6.3.windows.1