From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 10F8521C8F615 for ; Sun, 18 Jun 2017 19:39:55 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2017 19:41:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="982418799" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 18 Jun 2017 19:41:09 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:40:41 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:40:02 +0800 From: "Zeng, Star" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Fan, Jeff" , "Zeng, Star" Thread-Topic: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx Thread-Index: AQHS6JpupjbBrjEolEql4dVj9Zg86qIreXcA Date: Mon, 19 Jun 2017 02:40:01 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8D78@shsmsx102.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-3-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497835292-34476-3-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:39:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Bi, Dandan=20 Sent: Monday, June 19, 2017 9:21 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu ; Fan, = Jeff Subject: [patch 2/8] IntelFrameworkModulePkg: Update comments in SimpleText= InEx Update comments in SimpleTextInEx according to UEFI 2.7. Cc: Star Zeng Cc: Ruiyu Ni Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c | 10 +++++++--- .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 10 +++++++--- .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c | 15 +++++++++---= --- .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h | 16 ++++++++++--= ---- 4 files changed, 33 insertions(+), 18 deletions(-) diff --git a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c = b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c index 5825a04..12ee529 100644 --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c @@ -1,10 +1,10 @@ /** @file Routines implements SIMPLE_TEXT_IN protocol's interfaces based on 8042 i= nterfaces provided by Ps2KbdCtrller.c. =20 -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -531,13 +531,17 @@ Exit: /** Register a notification function for a particular keystroke for the in= put device. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled= in with the keystroke - information data for the key that wa= s pressed. + information data for the key that wa= s pressed.If KeyData.Key, + KeyData.KeyState.KeyToggleState and = KeyData.KeyState.KeyShiftState + are 0, then any incomplete keystroke= will trigger a notification of + the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called = when the key - sequence is typed specified by KeyDa= ta. + sequence is typed specified by KeyDa= ta.This notification function + should be called at <=3DTPL_CALLBACK= . @param NotifyHandle Points to the unique handle assigned= to the registered notification. =20 @retval EFI_SUCCESS The notification function was regist= ered successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for nec= esssary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or KeyNotifi= cationFunction is NULL. diff --git a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h b= /IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h index 82aa5a6..656d759 100644 --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h @@ -1,9 +1,9 @@ /** @file PS/2 keyboard driver header file =20 -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -492,13 +492,17 @@ KeyboardSetState ( /** Register a notification function for a particular keystroke for the in= put device. =20 @param This - Protocol instance pointer. @param KeyData - A pointer to a buffer that is filled = in with the keystroke - information data for the key that was presse= d. + information data for the key that was= pressed.If KeyData.Key, + KeyData.KeyState.KeyToggleState and K= eyData.KeyState.KeyShiftState + are 0, then any incomplete keystroke = will trigger a notification of + the KeyNotificationFunction. @param KeyNotificationFunction - Points to the function to be called w= hen the key - sequence is typed specified by KeyData. + sequence is typed specified by KeyDat= a.This notification function + should be called at <=3DTPL_CALLBACK. @param NotifyHandle - Points to the unique handle assigned = to the registered notification. =20 @retval EFI_SUCCESS - The notification function was regist= ered successfully. @retval EFI_OUT_OF_RESOURCES - Unable to allocate resources for nec= esssary data structures. @retval EFI_INVALID_PARAMETER - KeyData or NotifyHandle is NULL. diff --git a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard= .c b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c index 742d009..b04c340 100644 --- a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c +++ b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c @@ -2311,21 +2311,24 @@ Exit: /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in = with the keystroke=20 - information data for the key that was pr= essed. + information data for the key that was pr= essed.If KeyData.Key, + KeyData.KeyState.KeyToggleState and KeyD= ata.KeyState.KeyShiftState + are 0, then any incomplete keystroke wil= l trigger a notification of + the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called when= the key=20 - sequence is typed specified by KeyData. = =20 - @param NotifyHandle Points to the unique handle assigned to = the registered notification. =20 + sequence is typed specified by KeyData.T= his notification function + should be called at <=3DTPL_CALLBACK. + @param NotifyHandle Points to the unique handle assigned to = the registered notification. =20 - =20 @retval EFI_SUCCESS The notification function was registered= successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesss= ary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. - =20 -**/ =20 + +**/ EFI_STATUS EFIAPI BiosKeyboardRegisterKeyNotify ( IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, IN EFI_KEY_DATA *KeyData, diff --git a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard= .h b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h index f38411a..c64a131 100644 --- a/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h +++ b/IntelFrameworkModulePkg/Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h @@ -1,8 +1,8 @@ /** @file =20 -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
=20 This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -633,21 += 633,25 @@ BiosKeyboardSetState ( /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in = with the keystroke=20 - information data for the key that was pr= essed. + information data for the key that was pr= essed.If KeyData.Key, + KeyData.KeyState.KeyToggleState and KeyD= ata.KeyState.KeyShiftState + are 0, then any incomplete keystroke wil= l trigger a notification of + the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called when= the key=20 - sequence is typed specified by KeyData. = =20 - @param NotifyHandle Points to the unique handle assigned to = the registered notification. =20 + sequence is typed specified by KeyData.T= his notification function + should be called at <=3DTPL_CALLBACK. + @param NotifyHandle Points to the unique handle assigned to = the registered notification. =20 =20 @retval EFI_SUCCESS The notification function was registered= successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesss= ary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. - =20 -**/ =20 + +**/ EFI_STATUS EFIAPI BiosKeyboardRegisterKeyNotify ( IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, IN EFI_KEY_DATA *KeyData, -- 1.9.5.msysgit.1