From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1B5521C8F615 for ; Sun, 18 Jun 2017 19:41:56 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 18 Jun 2017 19:43:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="982419106" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 18 Jun 2017 19:43:17 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:43:16 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:43:13 +0800 From: "Zeng, Star" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zeng, Star" Thread-Topic: [patch 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR according to UEFI2.7 Thread-Index: AQHS6Jp5gV0H2wlcG0qR+e4FJbX2eqIrehag Date: Mon, 19 Jun 2017 02:43:13 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8DA4@shsmsx102.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-6-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497835292-34476-6-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR according to UEFI2.7 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:41:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please update the " Physical address of the first byte of the memory region. " to " Physical address of the first byte in the memory region. " instead of removing it. Thanks, Star -----Original Message----- From: Bi, Dandan=20 Sent: Monday, June 19, 2017 9:21 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zeng, Star Subject: [patch 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR accor= ding to UEFI2.7 Cc: Liming Gao Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdePkg/Include/Uefi/UefiSpec.h | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.= h index 57cb4e8..5774470 100644 --- a/MdePkg/Include/Uefi/UefiSpec.h +++ b/MdePkg/Include/Uefi/UefiSpec.h @@ -3,11 +3,11 @@ =20 This include file must contain things defined in the UEFI 2.6 specificat= ion. If a code construct is defined in the UEFI 2.6 specification it must be = included by this include file. =20 -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availabl= e under the terms and conditions of the BSD License that accompanies this = distribution. =20 The full text of the license may be found at http://opensource.org/licenses/bsd-license.php. = =20 =20 @@ -101,25 +101,32 @@ typedef enum { /// /// Definition of an EFI memory descriptor. /// typedef struct { /// - /// Type of the memory region. See EFI_MEMORY_TYPE. + /// Type of the memory region. + /// Type EFI_MEMORY_TYPE is defined in the /// AllocatePages()=20 + function description. /// UINT32 Type; /// - /// Physical address of the first byte of the memory region. Must align= ed - /// on a 4 KB boundary. + /// PhysicalStart must be aligned on a 4 KiB /// boundary, and must=20 + not be above 0xfffffffffffff000. Type /// EFI_PHYSICAL_ADDRESS is=20 + defined in the AllocatePages() function description /// EFI_PHYSICAL_ADDRESS PhysicalStart; /// - /// Virtual address of the first byte of the memory region. Must aligne= d - /// on a 4 KB boundary. + /// Virtual address of the first byte in the memory region. + /// VirtualStart must be aligned on a 4 KiB boundary, /// and must=20 + not be above 0xfffffffffffff000. /// EFI_VIRTUAL_ADDRESS VirtualStart; /// - /// Number of 4KB pages in the memory region. + /// NumberOfPagesNumber of 4 KiB pages in the memory region. + /// NumberOfPages must not be 0, and must not be any value /// that=20 + would represent a memory page with a start address, /// either=20 + physical or virtual, above 0xfffffffffffff000. /// UINT64 NumberOfPages; /// /// Attributes of the memory region that describe the bit mask of capabi= lities /// for that memory region, and not necessarily the current settings for= that -- 1.9.5.msysgit.1