Re: [patch 8/8] MdeModulePkg: Clean ACPI 2.0 characters in UEFI spec

["Zeng, Star" <star.zeng@intel.com>]

Dandan,

Seemingly, there are some missing changes in RootBridgeIoConfiguration(), please double confirm that.

Thanks,
Star
-----Original Message-----
From: Bi, Dandan 
Sent: Monday, June 19, 2017 9:22 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [patch 8/8] MdeModulePkg: Clean ACPI 2.0 characters in UEFI spec

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c                  | 6 +++---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h                  | 6 +++---
 MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h   | 6 +++---
 MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
index 3b3b53a..cc7125e 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c
@@ -1,9 +1,9 @@
 /** @file
   EFI PCI IO protocol functions implementation for PCI Bus module.
 
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials  are licensed and made available under the terms and conditions of the BSD License  which accompanies this distribution.  The full text of the license may be found at  http://opensource.org/licenses/bsd-license.php
 
@@ -1836,16 +1836,16 @@ GetMmioAddressTranslationOffset (
   @param  This                  A pointer to the EFI_PCI_IO_PROTOCOL instance.
   @param  BarIndex              The BAR index of the standard PCI Configuration header to use as the
                                 base address for resource range. The legal range for this field is 0..5.
   @param  Supports              A pointer to the mask of attributes that this PCI controller supports
                                 setting for this BAR with SetBarAttributes().
-  @param  Resources             A pointer to the ACPI 2.0 resource descriptors that describe the current
+  @param  Resources             A pointer to the resource descriptors that describe the current
                                 configuration of this BAR of the PCI controller.
 
   @retval EFI_SUCCESS           If Supports is not NULL, then the attributes that the PCI
                                 controller supports are returned in Supports. If Resources
-                                is not NULL, then the ACPI 2.0 resource descriptors that the PCI
+                                is not NULL, then the resource 
+ descriptors that the PCI
                                 controller is currently using are returned in Resources.
   @retval EFI_INVALID_PARAMETER Both Supports and Attributes are NULL.
   @retval EFI_UNSUPPORTED       BarIndex not valid for this PCI controller.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to allocate
                                 Resources.
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
index ac2def5..da3de39 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h
@@ -1,9 +1,9 @@
 /** @file
   EFI PCI IO protocol functions declaration for PCI Bus module.
 
-Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials  are licensed and made available under the terms and conditions of the BSD License  which accompanies this distribution.  The full text of the license may be found at  http://opensource.org/licenses/bsd-license.php
 
@@ -588,16 +588,16 @@ PciIoAttributes (
   @param  This                  A pointer to the EFI_PCI_IO_PROTOCOL instance.
   @param  BarIndex              The BAR index of the standard PCI Configuration header to use as the
                                 base address for resource range. The legal range for this field is 0..5.
   @param  Supports              A pointer to the mask of attributes that this PCI controller supports
                                 setting for this BAR with SetBarAttributes().
-  @param  Resources             A pointer to the ACPI 2.0 resource descriptors that describe the current
+  @param  Resources             A pointer to the resource descriptors that describe the current
                                 configuration of this BAR of the PCI controller.
 
   @retval EFI_SUCCESS           If Supports is not NULL, then the attributes that the PCI
                                 controller supports are returned in Supports. If Resources
-                                is not NULL, then the ACPI 2.0 resource descriptors that the PCI
+                                is not NULL, then the resource 
+ descriptors that the PCI
                                 controller is currently using are returned in Resources.
   @retval EFI_INVALID_PARAMETER Both Supports and Attributes are NULL.
   @retval EFI_UNSUPPORTED       BarIndex not valid for this PCI controller.
   @retval EFI_OUT_OF_RESOURCES  There are not enough resources available to allocate
                                 Resources.
diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h
index 1fec88b..d3dfb57 100644
--- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h
+++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h
@@ -1,10 +1,10 @@
 /** @file
 
   The PCI Root Bridge header file.
 
-Copyright (c) 1999 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 1999 - 2017, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials  are licensed and made available under the terms and conditions of the BSD License  which accompanies this distribution.  The full text of the license may be found at  http://opensource.org/licenses/bsd-license.php
 
@@ -552,14 +552,14 @@ RootBridgeIoSetAttributes (  ;
 
 /**
 
   Retrieves the current resource settings of this PCI root bridge
-  in the form of a set of ACPI 2.0 resource descriptor.
+  in the form of a set of ACPI resource descriptor.
 
   @param This       -  Pointer to the EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL instance.
-  @param Resources  -  Pointer to the ACPI 2.0 resource descriptor that
+  @param Resources  -  Pointer to the resource descriptor that
                        describe the current configuration of this PCI root
                        bridge.
 
   @retval EFI_SUCCESS      -  Success.
   @retval EFI_UNSUPPORTED  -  Current configuration of the PCI root bridge diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
index 8e4f032..5068434 100644
--- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
+++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c
@@ -1558,24 +1558,24 @@ RootBridgeIoSetAttributes (
   return EFI_SUCCESS;
 }
 
 /**
   Retrieves the current resource settings of this PCI root bridge in the form
-  of a set of ACPI 2.0 resource descriptors.
+  of a set of ACPI resource descriptors.
 
   There are only two resource descriptor types from the ACPI Specification that
   may be used to describe the current resources allocated to a PCI root bridge.
   These are the QWORD Address Space Descriptor (ACPI 2.0 Section 6.4.3.5.1),
   and the End Tag (ACPI 2.0 Section 6.4.2.8). The QWORD Address Space
   Descriptor can describe memory, I/O, and bus number ranges for dynamic or
   fixed resources. The configuration of a PCI root bridge is described with one
   or more QWORD Address Space Descriptors followed by an End Tag.
 
   @param[in]   This        A pointer to the EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL.
-  @param[out]  Resources   A pointer to the ACPI 2.0 resource descriptors that
+  @param[out]  Resources   A pointer to the resource descriptors that
                            describe the current configuration of this PCI root
-                           bridge. The storage for the ACPI 2.0 resource
+                           bridge. The storage for the resource
                            descriptors is allocated by this function. The
                            caller must treat the return buffer as read-only
                            data, and the buffer must not be freed by the
                            caller.
 
--
1.9.5.msysgit.1