From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 159B621C8F615 for ; Sun, 18 Jun 2017 19:56:22 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2017 19:57:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="99246783" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 18 Jun 2017 19:57:42 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:57:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:57:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:57:40 +0800 From: "Zeng, Star" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [patch 8/8] MdeModulePkg: Clean ACPI 2.0 characters in UEFI spec Thread-Index: AQHS6JqDyZV7oq17dUe1CkAisK2jz6IrfiVw Date: Mon, 19 Jun 2017 02:57:39 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8DE8@shsmsx102.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-9-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497835292-34476-9-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 8/8] MdeModulePkg: Clean ACPI 2.0 characters in UEFI spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:56:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dandan, Seemingly, there are some missing changes in RootBridgeIoConfiguration(), p= lease double confirm that. Thanks, Star -----Original Message----- From: Bi, Dandan=20 Sent: Monday, June 19, 2017 9:22 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [patch 8/8] MdeModulePkg: Clean ACPI 2.0 characters in UEFI spec Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 6 +++--- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 6 +++--- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h | 6 +++--- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/= PciBusDxe/PciIo.c index 3b3b53a..cc7125e 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1,9 +1,9 @@ /** @file EFI PCI IO protocol functions implementation for PCI Bus module. =20 -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -1836,16 +1836,16 @@ GetMmioAddressTranslationOffset ( @param This A pointer to the EFI_PCI_IO_PROTOCOL insta= nce. @param BarIndex The BAR index of the standard PCI Configur= ation header to use as the base address for resource range. The legal= range for this field is 0..5. @param Supports A pointer to the mask of attributes that t= his PCI controller supports setting for this BAR with SetBarAttributes= (). - @param Resources A pointer to the ACPI 2.0 resource descrip= tors that describe the current + @param Resources A pointer to the resource descriptors that= describe the current configuration of this BAR of the PCI contr= oller. =20 @retval EFI_SUCCESS If Supports is not NULL, then the attribut= es that the PCI controller supports are returned in Suppor= ts. If Resources - is not NULL, then the ACPI 2.0 resource de= scriptors that the PCI + is not NULL, then the resource=20 + descriptors that the PCI controller is currently using are returned= in Resources. @retval EFI_INVALID_PARAMETER Both Supports and Attributes are NULL. @retval EFI_UNSUPPORTED BarIndex not valid for this PCI controller= . @retval EFI_OUT_OF_RESOURCES There are not enough resources available t= o allocate Resources. diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h b/MdeModulePkg/Bus/Pci/= PciBusDxe/PciIo.h index ac2def5..da3de39 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h @@ -1,9 +1,9 @@ /** @file EFI PCI IO protocol functions declaration for PCI Bus module. =20 -Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -588,16 +588,16 @@ PciIoAttributes ( @param This A pointer to the EFI_PCI_IO_PROTOCOL insta= nce. @param BarIndex The BAR index of the standard PCI Configur= ation header to use as the base address for resource range. The legal= range for this field is 0..5. @param Supports A pointer to the mask of attributes that t= his PCI controller supports setting for this BAR with SetBarAttributes= (). - @param Resources A pointer to the ACPI 2.0 resource descrip= tors that describe the current + @param Resources A pointer to the resource descriptors that= describe the current configuration of this BAR of the PCI contr= oller. =20 @retval EFI_SUCCESS If Supports is not NULL, then the attribut= es that the PCI controller supports are returned in Suppor= ts. If Resources - is not NULL, then the ACPI 2.0 resource de= scriptors that the PCI + is not NULL, then the resource=20 + descriptors that the PCI controller is currently using are returned= in Resources. @retval EFI_INVALID_PARAMETER Both Supports and Attributes are NULL. @retval EFI_UNSUPPORTED BarIndex not valid for this PCI controller= . @retval EFI_OUT_OF_RESOURCES There are not enough resources available t= o allocate Resources. diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h b/MdeMod= ulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h index 1fec88b..d3dfb57 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridge.h @@ -1,10 +1,10 @@ /** @file =20 The PCI Root Bridge header file. =20 -Copyright (c) 1999 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 1999 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -552,14 +552,14 @@ RootBridgeIoSetAttributes ( ; =20 /** =20 Retrieves the current resource settings of this PCI root bridge - in the form of a set of ACPI 2.0 resource descriptor. + in the form of a set of ACPI resource descriptor. =20 @param This - Pointer to the EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL inst= ance. - @param Resources - Pointer to the ACPI 2.0 resource descriptor that + @param Resources - Pointer to the resource descriptor that describe the current configuration of this PCI root bridge. =20 @retval EFI_SUCCESS - Success. @retval EFI_UNSUPPORTED - Current configuration of the PCI root bridge= diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c b/Mde= ModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c index 8e4f032..5068434 100644 --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c @@ -1558,24 +1558,24 @@ RootBridgeIoSetAttributes ( return EFI_SUCCESS; } =20 /** Retrieves the current resource settings of this PCI root bridge in the f= orm - of a set of ACPI 2.0 resource descriptors. + of a set of ACPI resource descriptors. =20 There are only two resource descriptor types from the ACPI Specification= that may be used to describe the current resources allocated to a PCI root br= idge. These are the QWORD Address Space Descriptor (ACPI 2.0 Section 6.4.3.5.1= ), and the End Tag (ACPI 2.0 Section 6.4.2.8). The QWORD Address Space Descriptor can describe memory, I/O, and bus number ranges for dynamic o= r fixed resources. The configuration of a PCI root bridge is described wit= h one or more QWORD Address Space Descriptors followed by an End Tag. =20 @param[in] This A pointer to the EFI_PCI_ROOT_BRIDGE_IO_PROTOCO= L. - @param[out] Resources A pointer to the ACPI 2.0 resource descriptors = that + @param[out] Resources A pointer to the resource descriptors that describe the current configuration of this PCI = root - bridge. The storage for the ACPI 2.0 resource + bridge. The storage for the resource descriptors is allocated by this function. The caller must treat the return buffer as read-onl= y data, and the buffer must not be freed by the caller. =20 -- 1.9.5.msysgit.1