public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments
Date: Mon, 19 Jun 2017 04:54:30 +0000	[thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8F8F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1497847586-18144-5-git-send-email-dandan.bi@intel.com>

Just found below comments in MdePkg.dec, should it be removed also?

  ##
  ## In UEFI 2.6 spec,this guid value is duplicate with
  ## EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to
  ## avoid the duplicate guid issue. So its value is not consistent with
  ## UEFI spec definition now. We have proposed to update UEFI spec to
  ## use this new guid. After new spec released, we will remove this
  ## comments.
  ##

Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dandan Bi
Sent: Monday, June 19, 2017 12:46 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdePkg/Include/Protocol/HiiImageDecoder.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/MdePkg/Include/Protocol/HiiImageDecoder.h b/MdePkg/Include/Protocol/HiiImageDecoder.h
index 48a1a97..34eb5e1 100644
--- a/MdePkg/Include/Protocol/HiiImageDecoder.h
+++ b/MdePkg/Include/Protocol/HiiImageDecoder.h
@@ -16,19 +16,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #ifndef __HII_IMAGE_DECODER_H__
 #define __HII_IMAGE_DECODER_H__
 
 #include <Protocol/HiiImage.h>
 
-
-//
-// In UEFI 2.6 spec,this guid value is duplicate with -// EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to -// avoid the duplicate guid issue. So its value is not consistent with -// UEFI spec definition now. We have proposed to update UEFI spec to -// use this new guid. After new spec released, we will remove this -// comments.
-//
 #define EFI_HII_IMAGE_DECODER_PROTOCOL_GUID \
   {0x9e66f251, 0x727c, 0x418c, { 0xbf, 0xd6, 0xc2, 0xb4, 0x25, 0x28, 0x18, 0xea }}
 
 
 #define EFI_HII_IMAGE_DECODER_NAME_JPEG_GUID \
--
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-06-19  4:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19  4:46 [PATCH v2 0/8] Update function comments according to UEFI2.7 spec Dandan Bi
2017-06-19  4:46 ` [PATCH v2 1/8] MdePkg/SimpleTextInEx: Update comments according to UEFI 2.7 spec Dandan Bi
2017-06-19  4:46 ` [PATCH v2 2/8] IntelFrameworkModulePkg: Update comments in SimpleTextInEx Dandan Bi
2017-06-19  4:46 ` [PATCH v2 3/8] MdeModulePkg: Update comments in SimpleTextInEx according to UEFI 2.7 Dandan Bi
2017-06-19  4:46 ` [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments Dandan Bi
2017-06-19  4:54   ` Zeng, Star [this message]
2017-06-19  4:58     ` Bi, Dandan
2017-06-19  4:46 ` [PATCH v2 5/8] MdePkg: Update comments in EFI_MEMORY_DESCRIPTOR according to UEFI2.7 Dandan Bi
2017-06-19  4:46 ` [PATCH v2 6/8] MdePkg: update comments in ResetSystem() " Dandan Bi
2017-06-19  4:46 ` [PATCH v2 7/8] MdePkg: Clean ACPI 2.0 characters in UEFI spec Dandan Bi
2017-06-19  4:46 ` [PATCH v2 8/8] MdeModulePkg: " Dandan Bi
2017-06-19  4:51 ` [PATCH v2 0/8] Update function comments according to UEFI2.7 spec Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B8E8F8F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox