From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7671921CB74D8 for ; Wed, 28 Jun 2017 20:05:41 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 20:07:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,278,1496127600"; d="scan'208";a="118690218" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2017 20:07:12 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 20:07:12 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 20:07:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002; Thu, 29 Jun 2017 11:07:10 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Wu, Hao A" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 0/3] Check timeout URB again after stopping endpoint Thread-Index: AQHS7/r04Y5kiLl3o0ybLgug3K1VvqI6RW+ggABZVwCAAIrGUA== Date: Thu, 29 Jun 2017 03:07:09 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8EFC81@shsmsx102.ccr.corp.intel.com> References: <20170628103959.397244-1-ruiyu.ni@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8EF871@shsmsx102.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5B9A76D5@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5B9A76D5@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] Check timeout URB again after stopping endpoint X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 03:05:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Get the point, thanks. Star -----Original Message----- From: Ni, Ruiyu=20 Sent: Thursday, June 29, 2017 10:50 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Tian, Feng ; Wu, Hao A Subject: RE: [edk2] [PATCH 0/3] Check timeout URB again after stopping endp= oint This patch supports a certain USB device that: 1. contain BULK IN endpoint 2. BULK read from HOST gets timeout if a. there is no data from the endpoint in the device b. the data comes late For now, I haven't found any other USB devices that meet the above conditio= ns except the Bluetooth host controller. Given the fact PEI USB functionality is merely to support USB storage acces= s, I don't have chance to test in PEI phase if I made the similar change. So I don't prefer to update the PEI XHCI module. If we need to update PEI XHCI in future, we could do a "cherry-pick" later,= with necessary unit test. Thanks/Ray > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, June 28, 2017 9:31 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Wu, Hao A > Subject: RE: [edk2] [PATCH 0/3] Check timeout URB again after stopping=20 > endpoint >=20 > Ray, >=20 > Does XhciPei need the same update? >=20 >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Ruiyu Ni > Sent: Wednesday, June 28, 2017 6:40 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/3] Check timeout URB again after stopping=20 > endpoint >=20 > This fixes BULK data loss when transfer is detected as timeout but=20 > finished just before stopping endpoint. >=20 > Ruiyu Ni (3): > MdeModulePkg/XhciDxe: Refine IsTransferRingTrb and IsAsyncIntTrb > MdeModulePkg/XhciDxe: Dump the CMD/EVENT/INT/BULK ring information > MdeModulePkg/XhciDxe: Check timeout URB again after stopping=20 > endpoint >=20 > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 31 +++-- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 3 +- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 190 > +++++++++++++++++++++---------- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 9 +- > 4 files changed, 159 insertions(+), 74 deletions(-) >=20 > -- > 2.12.2.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel