From: "Zeng, Star" <star.zeng@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global variable
Date: Thu, 29 Jun 2017 14:11:09 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B8EFFC7@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170629083221.485184-3-ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Thursday, June 29, 2017 4:32 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global variable
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
index f61e65e151..64f2da5ce9 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
@@ -1,7 +1,7 @@
/** @file
Reset Architectural Protocol implementation
- Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2006 - 2017, Intel Corporation. All rights
+ reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License @@ -15,11 +15,6 @@
#include "ResetSystem.h"
-//
-// The handle onto which the Reset Architectural Protocol is installed -// -EFI_HANDLE mResetHandle = NULL;
-
/**
The driver's entry point.
@@ -40,6 +35,7 @@ InitializeResetSystem (
)
{
EFI_STATUS Status;
+ EFI_HANDLE Handle;
//
// Make sure the Reset Architectural Protocol is not already installed in the system @@ -54,8 +50,9 @@ InitializeResetSystem (
//
// Now install the Reset RT AP on a new handle
//
+ Handle = NULL;
Status = gBS->InstallMultipleProtocolInterfaces (
- &mResetHandle,
+ &Handle,
&gEfiResetArchProtocolGuid,
NULL,
NULL
--
2.12.2.windows.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-06-29 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 8:32 [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol Ruiyu Ni
2017-06-29 8:32 ` [PATCH 1/3] MdePkg: Add ResetNotification protocol definition Ruiyu Ni
2017-06-29 14:10 ` Zeng, Star
2017-06-29 8:32 ` [PATCH 2/3] MdeModulePkg/ResetSystem: Remove unnecessary global variable Ruiyu Ni
2017-06-29 14:11 ` Zeng, Star [this message]
2017-06-29 8:32 ` [PATCH 3/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol Ruiyu Ni
2017-06-29 14:30 ` Zeng, Star
2017-06-30 1:27 ` Ni, Ruiyu
2017-07-01 21:04 ` [PATCH 0/3] " Laszlo Ersek
2017-07-03 11:49 ` Ard Biesheuvel
2017-07-03 12:09 ` Leif Lindholm
2017-07-03 17:30 ` Laszlo Ersek
2017-07-03 17:31 ` Ard Biesheuvel
2017-07-03 17:36 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B8EFFC7@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox