From: "Zeng, Star" <star.zeng@intel.com>
To: "Song, BinX" <binx.song@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg: Delete useless case code
Date: Mon, 7 Aug 2017 07:01:39 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B90B965@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1025830C4@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Song, BinX
Sent: Thursday, August 3, 2017 1:53 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH] MdeModulePkg: Delete useless case code
- Delete useless case code to fix /WHOLEARCHIVE build
error with VS2015 tool chain
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song <binx.song@intel.com>
---
.../Universal/RegularExpressionDxe/Oniguruma/reggnu.c | 9 ---------
.../Universal/RegularExpressionDxe/Oniguruma/regposix.c | 12 ------------
2 files changed, 21 deletions(-)
diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c
index 1b52328..7fa5819 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/reggnu.c
@@ -151,15 +151,6 @@ re_mbcinit(int mb_code)
case RE_MBCTYPE_ASCII:
enc = ONIG_ENCODING_ASCII;
break;
- case RE_MBCTYPE_EUC:
- enc = ONIG_ENCODING_EUC_JP;
- break;
- case RE_MBCTYPE_SJIS:
- enc = ONIG_ENCODING_SJIS;
- break;
- case RE_MBCTYPE_UTF8:
- enc = ONIG_ENCODING_UTF8;
- break;
default:
return ;
break;
diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c
index 06cad48..cfca25e 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regposix.c
@@ -238,18 +238,6 @@ reg_set_encoding(int mb_code)
case REG_POSIX_ENCODING_ASCII:
enc = ONIG_ENCODING_ASCII;
break;
- case REG_POSIX_ENCODING_EUC_JP:
- enc = ONIG_ENCODING_EUC_JP;
- break;
- case REG_POSIX_ENCODING_SJIS:
- enc = ONIG_ENCODING_SJIS;
- break;
- case REG_POSIX_ENCODING_UTF8:
- enc = ONIG_ENCODING_UTF8;
- break;
- case REG_POSIX_ENCODING_UTF16_BE:
- enc = ONIG_ENCODING_UTF16_BE;
- break;
case REG_POSIX_ENCODING_UTF16_LE:
enc = ONIG_ENCODING_UTF16_LE;
break;
--
2.10.2.windows.1
prev parent reply other threads:[~2017-08-07 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 5:53 [PATCH] MdeModulePkg: Delete useless case code Song, BinX
2017-08-07 7:01 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B90B965@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox