Re: [PATCH v4 0/6] read-only UDF file system support

["Zeng, Star" <star.zeng@intel.com>]

Trusted Ray to help review this series. :)


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Monday, September 4, 2017 6:04 PM
To: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; edk2-devel@lists.01.org; Andrew Fish <afish@apple.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2] [PATCH v4 0/6] read-only UDF file system support

On 08/24/17 19:56, Paulo Alcantara wrote:
> Hi,
> 
> This series introduces read-only UDF file system support in EDK2. As 
> Laszlo (or Red Hat) seemed to be interested in such support, I'm 
> posting it again after ~3 years.
> 
> The idea is not replacing the default FAT file system, nor breaking 
> any existing file system support, but extending EDK2 with a new file 
> system that might be useful for some people who are looking for 
> specific file system features that current FAT doesn't support.
> 
> Originally the driver was written to support UDF file systems as 
> specified by OSTA Universal Disk Format Specification 2.60. However, 
> some Windows 10 Enterprise ISO (UDF bridge) images that I tested 
> supported a revision of 1.02 thus I had to rework the driver a little 
> bit to support such revision as well.
> 
> v2:
>  - Rework to _partially_ support UDF revisions <2.60.
>  - Use existing CDROM_VOLUME_DESCRIPTOR structure defined in Eltorito.h
>    instead of creating another one (UDF_VOLUME_DESCRIPTOR).
>  - Fixed UdfDxe to correctly follow UEFI driver model.
>  - Use HARDDRIVE_DEVICE_PATH instead of a vendor-defined one.
>  - Detect UDF file systems only in PartitionDxe, and let UdfDxe driver
>    check for specific UDF device path to decide whether or not install
>    SimpleFs protocol.
>  - Place MdePkg changes in a separate patch.
> v3:
>  - Install UDF partition child handles with a Vendor-Defined Media
>    Device Path.
>  - Changed UdfDxe to check for Vendor-Defined Media Device Paths with a
>    specific UDF file system GUID when determining to whether or not
>    start the driver.
>  - Removed leading TAB chars in some source files identified by
>    PatchCheck.py tool.

Ping -- can we please get feedback on this? (Patches #1 through #3.)

Thanks
Laszlo

> v4:
>  - Added missing R-b's.
> 
> Repo:   https://github.com/pcacjr/edk2.git
> Branch: udf-fs-v4
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Mark Doran <mark.doran@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: hao.a.wu@intel.com
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
> ---
> 
> Paulo Alcantara (6):
>   MdePkg: Add UDF volume structure definitions
>   MdeModulePkg/PartitionDxe: Add UDF file system support
>   MdeModulePkg: Initial UDF/ECMA-167 file system support
>   OvmfPkg: Enable UDF file system support
>   ArmVirtPkg: Enable UDF file system support
>   Nt32Pkg: Enable UDF file system support
> 
>  ArmVirtPkg/ArmVirtQemu.dsc                         |    3 +-
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc               |    3 +-
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                   |    3 +-
>  ArmVirtPkg/ArmVirtXen.dsc                          |    3 +-
>  ArmVirtPkg/ArmVirtXen.fdf                          |    1 +
>  .../Universal/Disk/PartitionDxe/Partition.c        |    9 +-
>  .../Universal/Disk/PartitionDxe/Partition.h        |   32 +-
>  .../Universal/Disk/PartitionDxe/PartitionDxe.inf   |    3 +-
>  MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c     |  318 +++
>  MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c |  185 ++
>  MdeModulePkg/Universal/Disk/UdfDxe/File.c          |  903 ++++++++
>  MdeModulePkg/Universal/Disk/UdfDxe/FileName.c      |  195 ++
>  .../Universal/Disk/UdfDxe/FileSystemOperations.c   | 2447 ++++++++++++++++++++
>  MdeModulePkg/Universal/Disk/UdfDxe/Udf.c           |  344 +++
>  MdeModulePkg/Universal/Disk/UdfDxe/Udf.h           | 1244 ++++++++++
>  MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf      |   66 +
>  MdePkg/Include/IndustryStandard/Udf.h              |   60 +
>  Nt32Pkg/Nt32Pkg.dsc                                |    1 +
>  Nt32Pkg/Nt32Pkg.fdf                                |    1 +
>  OvmfPkg/OvmfPkgIa32.dsc                            |    1 +
>  OvmfPkg/OvmfPkgIa32.fdf                            |    1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                         |    1 +
>  OvmfPkg/OvmfPkgIa32X64.fdf                         |    1 +
>  OvmfPkg/OvmfPkgX64.dsc                             |    1 +
>  OvmfPkg/OvmfPkgX64.fdf                             |    1 +
>  25 files changed, 5816 insertions(+), 11 deletions(-)  create mode 
> 100644 MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/ComponentName.c
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/File.c
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/FileName.c
>  create mode 100644 
> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.c
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/Udf.h
>  create mode 100644 MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>  create mode 100644 MdePkg/Include/IndustryStandard/Udf.h
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel