From: "Zeng, Star" <star.zeng@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 1/5] MdeModulePkg/UsbBusDxe: log warning message at DEBUG_WARN level
Date: Tue, 5 Sep 2017 02:00:40 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B93A280@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170904201403.6445-2-lersek@redhat.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Tuesday, September 5, 2017 4:14 AM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH 1/5] MdeModulePkg/UsbBusDxe: log warning message at DEBUG_WARN level
"UsbSelectConfig: failed to connect driver %r, ignored" is an error message, but it states at once that the error condition will not affect the control flow. Degrade the report to DEBUG_WARN.
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
index b0e6b835ac24..62645d9bdedb 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
@@ -440,7 +440,11 @@ UsbSelectConfig (
Status = UsbConnectDriver (UsbIf);
if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_ERROR, "UsbSelectConfig: failed to connect driver %r, ignored\n", Status));
+ DEBUG ((
+ DEBUG_WARN,
+ "UsbSelectConfig: failed to connect driver %r, ignored\n",
+ Status
+ ));
}
}
--
2.14.1.3.gb7cf6e02401b
next prev parent reply other threads:[~2017-09-05 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 20:13 [PATCH 0/5] MdeModulePkg, UefiCpuPkg, OvmfPkg: lower some DEBUGs from ERROR level Laszlo Ersek
2017-09-04 20:13 ` [PATCH 1/5] MdeModulePkg/UsbBusDxe: log warning message at DEBUG_WARN level Laszlo Ersek
2017-09-05 2:00 ` Zeng, Star [this message]
2017-09-04 20:14 ` [PATCH 2/5] UefiCpuPkg/CpuDxe: log informative message at DEBUG_INFO level Laszlo Ersek
2017-09-05 0:16 ` Dong, Eric
2017-09-04 20:14 ` [PATCH 3/5] OvmfPkg/PlatformPei: " Laszlo Ersek
2017-09-04 20:14 ` [PATCH 4/5] OvmfPkg/PlatformBootManagerLib: log informative message at DEBUG_INFO lvl Laszlo Ersek
2017-09-04 20:14 ` [PATCH 5/5] OvmfPkg/SataControllerDxe: log informative message at DEBUG_INFO level Laszlo Ersek
2017-09-11 20:42 ` [PATCH 0/5] MdeModulePkg, UefiCpuPkg, OvmfPkg: lower some DEBUGs from ERROR level Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B93A280@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox