From: "Zeng, Star" <star.zeng@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride
Date: Mon, 30 Oct 2017 08:42:48 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9AFC0B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20171027065438.284440-1-ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu Ni
Sent: Friday, October 27, 2017 2:55 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride
It's a regression of below commit:
SHA-1: 8be37a5cee700777ca8e8e8a34cc2225b21931a7
* MdeModulePkg/SecurityStubDxe: Defer 3rd party image before EndOfDxe
When PciBus driver fails to load the Option ROM, it doesn't produce BusOverride protocol. It was a correct behavior before the above commit. But due to the above commit, BusOverride protocol never is produced by PciBus driver.
The patch fixes this issue using the following solution:
1. PciBus records the image device path when LoadImage fails.
2. Override.GetDriver() tries to look for the image handle using
the stored image device path.
Ruiyu Ni (3):
MdeModulePkg/PciBus: Refine EFI_PCI_ROM_IMAGE_MAPPING
MdeModulePkg/PciBus: Don't create entry when recording ImageHandle
MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride
MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 7 +-
MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 3 +-
MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 4 +-
MdeModulePkg/Bus/Pci/PciBusDxe/PciDriverOverride.c | 147 ++++++++++++++------- MdeModulePkg/Bus/Pci/PciBusDxe/PciDriverOverride.h | 17 ++-
.../Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 21 ++-
MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c | 99 ++++++++------
MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.h | 10 +-
8 files changed, 190 insertions(+), 118 deletions(-)
--
2.12.2.windows.2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-10-30 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 6:54 [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride Ruiyu Ni
2017-10-27 6:54 ` [PATCH 1/3] MdeModulePkg/PciBus: Refine EFI_PCI_ROM_IMAGE_MAPPING Ruiyu Ni
2017-10-27 6:54 ` [PATCH 2/3] MdeModulePkg/PciBus: Don't create entry when recording ImageHandle Ruiyu Ni
2017-10-27 6:54 ` [PATCH 3/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride Ruiyu Ni
2017-10-30 8:42 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B9AFC0B@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox