From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66DC7203525EE for ; Mon, 30 Oct 2017 01:39:29 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2017 01:43:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,319,1505804400"; d="scan'208";a="143789379" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 30 Oct 2017 01:43:19 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Oct 2017 01:43:13 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 30 Oct 2017 01:43:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 30 Oct 2017 16:42:49 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride Thread-Index: AQHTTvB+Uq796OBJr0O0UYn6PtOmk6L8GC8w Date: Mon, 30 Oct 2017 08:42:48 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9AFC0B@shsmsx102.ccr.corp.intel.com> References: <20171027065438.284440-1-ruiyu.ni@intel.com> In-Reply-To: <20171027065438.284440-1-ruiyu.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 08:39:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiy= u Ni Sent: Friday, October 27, 2017 2:55 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/3] MdeModulePkg/PciBus: Fix bug that doesn't produ= ce BusOverride It's a regression of below commit: SHA-1: 8be37a5cee700777ca8e8e8a34cc2225b21931a7 * MdeModulePkg/SecurityStubDxe: Defer 3rd party image before EndOfDxe When PciBus driver fails to load the Option ROM, it doesn't produce BusOver= ride protocol. It was a correct behavior before the above commit. But due t= o the above commit, BusOverride protocol never is produced by PciBus driver= . The patch fixes this issue using the following solution: 1. PciBus records the image device path when LoadImage fails. 2. Override.GetDriver() tries to look for the image handle using the stored image device path. Ruiyu Ni (3): MdeModulePkg/PciBus: Refine EFI_PCI_ROM_IMAGE_MAPPING MdeModulePkg/PciBus: Don't create entry when recording ImageHandle MdeModulePkg/PciBus: Fix bug that doesn't produce BusOverride MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 7 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 3 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c | 4 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciDriverOverride.c | 147 ++++++++++++++---= ---- MdeModulePkg/Bus/Pci/PciBusDxe/PciDriverOverride.h | 17 ++- .../Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 21 ++- MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.c | 99 ++++++++------ MdeModulePkg/Bus/Pci/PciBusDxe/PciRomTable.h | 10 +- 8 files changed, 190 insertions(+), 118 deletions(-) -- 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel