From: "Zeng, Star" <star.zeng@intel.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>,
"heyi.guo@linaro.org" <heyi.guo@linaro.org>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>,
Anthony PERARD <anthony.perard@citrix.com>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: Xen Console input very slow in recent UEFI
Date: Thu, 2 Nov 2017 01:43:47 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9B0CA8@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CAEC2CxqLN-YhhQtT2zG5pkfPNtabR7HF65nh=0U_9jZ2Euw7wg@mail.gmail.com>
Patch has been just sent at https://lists.01.org/pipermail/edk2-devel/2017-November/016837.html.
Thanks,
Star
-----Original Message-----
From: Julien Grall [mailto:julien.grall@linaro.org]
Sent: Wednesday, November 1, 2017 8:47 PM
To: Zeng, Star <star.zeng@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org>; heyi.guo@linaro.org; Ni, Ruiyu <ruiyu.ni@intel.com>; Anthony PERARD <anthony.perard@citrix.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2] Xen Console input very slow in recent UEFI
Hi Zeng,
On 30 October 2017 at 01:09, Zeng, Star <star.zeng@intel.com> wrote:
> I do not think SerialDxe should handle EFI_INVALID_PARAMETER return value from SerialPortSetAttributes().
> If the EFI_INVALID_PARAMETER is because of Timeout value, the Timeout value definitely should not be updated.
> If the EFI_INVALID_PARAMETER is because of other parameters, the status should be returned to the caller.
Fair enough. Are you going to resend the change you suggest with a commit message?
Cheers,
--
Julien Grall
prev parent reply other threads:[~2017-11-02 1:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 11:05 Xen Console input very slow in recent UEFI Julien Grall
2017-10-26 15:13 ` Laszlo Ersek
2017-10-26 15:20 ` Laszlo Ersek
2017-10-26 18:31 ` Julien Grall
2017-10-27 3:20 ` Zeng, Star
2017-10-27 12:38 ` Laszlo Ersek
2017-10-27 13:19 ` Julien Grall
2017-10-27 15:43 ` Laszlo Ersek
2017-10-30 1:09 ` Zeng, Star
2017-11-01 12:46 ` Julien Grall
2017-11-02 1:43 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B9B0CA8@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox