From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E8E5C20349D99 for ; Sun, 12 Nov 2017 19:27:50 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2017 19:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,387,1505804400"; d="scan'208";a="175064224" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 12 Nov 2017 19:31:56 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 12 Nov 2017 19:31:56 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 12 Nov 2017 19:31:55 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 13 Nov 2017 11:31:53 +0800 From: "Zeng, Star" To: "Wu, Hao A" , Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Kinney, Michael D" CC: "Gao, Liming" , "Tian, Feng" , "Dong, Eric" , "Zeng, Star" Thread-Topic: [RFC PATCH 0/2] quirks handling for SDHCI controllers Thread-Index: AQHTWiwVphriOPj+Yk6ysAElt/Ght6MRq0+Q Date: Mon, 13 Nov 2017 03:31:53 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9B461F@shsmsx102.ccr.corp.intel.com> References: <20171110135847.361-1-ard.biesheuvel@linaro.org> In-Reply-To: <20171110135847.361-1-ard.biesheuvel@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC PATCH 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 03:27:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao, Could you help do the evaluation on this RFC? Thanks, Star -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]=20 Sent: Friday, November 10, 2017 9:59 PM To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Kinney, Michael D Cc: Gao, Liming ; Zeng, Star ; T= ian, Feng ; Dong, Eric ; Ard Bies= heuvel Subject: [RFC PATCH 0/2] quirks handling for SDHCI controllers Many SDHCI implementations exist that are almost spec complicant, and could= be driver by the generic SD/MMC host controller driver except for some min= imal necessary init time tweaks. Adding such tweaks to the generic driver is undesirable. On the other hand,= forking the driver for every platform that has such a SDHCI controller is = problematic when it comes to upstreaming and ongoing maintenance (which is = arguably the point of upstreaming in the first place). So these patches propose a workaround that is minimally invasive on the EDK2 side, but gives platforms a lot of leeway when it comes to applying SD= HCI quirks. Ard Biesheuvel (2): MdeModulePkg: introduce SD/MMC override protocol MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 111 +++++++++++++++= ++++- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 ++ MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 2 + MdeModulePkg/Include/Protocol/SdMmcOverride.h | 95 +++++++++++++++= ++ MdeModulePkg/MdeModulePkg.dec | 3 + 5 files changed, 212 insertions(+), 5 deletions(-) create mode 100644 Mde= ModulePkg/Include/Protocol/SdMmcOverride.h -- 2.11.0