From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D5EB21C913BB for ; Tue, 21 Nov 2017 23:52:24 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2017 23:56:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,436,1505804400"; d="scan'208";a="178766949" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 21 Nov 2017 23:56:40 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Nov 2017 23:56:40 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 21 Nov 2017 23:56:39 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Wed, 22 Nov 2017 15:56:37 +0800 From: "Zeng, Star" To: Laszlo Ersek , "Wang, Jian J" CC: "edk2-devel@lists.01.org" , "Yao, Jiewen" , "Zeng, Star" Thread-Topic: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map Thread-Index: AQHTYpBzbsIKtrVZtkqb+1CChGEbb6MeUL8AgAG4aqA= Date: Wed, 22 Nov 2017 07:56:37 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BA58E@shsmsx102.ccr.corp.intel.com> References: <20171121061725.11028-1-jian.j.wang@intel.com> <2e083f9d-4009-dd3e-c845-108f0c1eb24a@redhat.com> In-Reply-To: <2e083f9d-4009-dd3e-c845-108f0c1eb24a@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2UzY2QyMzQtYWIzNi00N2RkLWE3MWMtMDg0MGY0M2I4ZWEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJkMXRpcnJLOXBHRVpIS05JWkp0UHRlTWFMNGJyS1dyMWJcL3hsQlhhVzB5aFlTZG1hNGpkTko2UjU1WUdBNjRHTSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 07:52:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable How about we have the v6 patch series in first with the feedback from Jiewe= n (about comments) and you (about MemoryMapStart) addressed? Then we can have a separated patch for the merging. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Tuesday, November 21, 2017 9:38 PM To: Wang, Jian J Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memor= y map Jian, On 11/21/17 07:17, Jian J Wang wrote: >> v7: >> Merge memory map after filtering paging attributes >=20 > More than one entry of RT_CODE memory might cause boot problem for=20 > some old OSs. This patch will fix this issue to keep OS compatibility=20 > as much as possible. >=20 > Jian J Wang (2): > MdeModulePkg/DxeCore: Filter out all paging capabilities > UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map >=20 > MdeModulePkg/Core/Dxe/DxeMain.h | 18 ++++++ > MdeModulePkg/Core/Dxe/Mem/Page.c | 21 +++++++ > MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1 - > UefiCpuPkg/CpuDxe/CpuPageTable.c | 94 +++++++++++++++++++++-= ------ > 4 files changed, 112 insertions(+), 22 deletions(-) >=20 I don't have capacity to retest and re-review the series. Considering the following two options, I like none of them: (1) Version 7 is merged with my feedback tags from v6. I don't like this be= cause I didn't review or test version 7. (2) Version 7 is merged without my feedback tags. I don't like this because= I've put a lot of BZ writeup, and patch review and testing effort for this= series, and I'd like the commit log to reflect that. Instead, I would like to request the following, for v8: Please submit a series that consists of three patches: - patch v8 1/3: identical to v6 1/2, except for the code comment update, - patch v8 2/3: identical to v6 2/2, - patch v8 3/3: please implement the merging of the memory map as a separat= e patch. Patches v8 1/3 and 2/3 should include *both* my Tested-by *and* my Reviewed= -by tags, from v6. Patch v8 3/3 should be reviewed / tested separately by others. I don't thin= k I can find the capacity for that at the moment. This approach will correctly reflect all the work done thus far, and it wil= l provide the desired result for the code as well. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel