From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 634D021A1099A for ; Sun, 26 Nov 2017 17:45:00 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2017 17:49:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,462,1505804400"; d="scan'208";a="6406095" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 26 Nov 2017 17:49:21 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 26 Nov 2017 17:49:20 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 27 Nov 2017 09:49:18 +0800 From: "Zeng, Star" To: Julien Grall , "Dong, Eric" , "pankaj.bansal@nxp.com" , "lersek@redhat.com" , "leif.lindholm@linaro.org" CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes Thread-Index: AQHTZUAs7xqjE8wW4EaZJR/m78gwrKMneLAQ Date: Mon, 27 Nov 2017 01:49:17 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BC16F@shsmsx102.ccr.corp.intel.com> References: <20171124162030.31156-1-julien.grall@linaro.org> <20171124162030.31156-2-julien.grall@linaro.org> In-Reply-To: <20171124162030.31156-2-julien.grall@linaro.org> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 01:45:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Could you also update the description for EFI_SERIAL_SET_ATTRIBUTES in MdeP= kg/Include/Protocol/SerialIo.h? That could be done in a separated patch. Thanks, Star -----Original Message----- From: Julien Grall [mailto:julien.grall@linaro.org]=20 Sent: Saturday, November 25, 2017 12:20 AM To: Zeng, Star ; Dong, Eric ; pan= kaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org Cc: edk2-devel@lists.01.org; Julien Grall Subject: [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVI= CE_ERROR for SetAttributes Per the UEFIv2.7 spec, EFI_DEVICE_ERROR is returned when the serial device = is not functioning correctly. Update the description to avoid confusion. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Uni= versal/SerialDxe/SerialIo.c index 964d0329f4..5946a6e2f3 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -265,7 +265,7 @@ SerialReset ( stop bits. =20 @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device could not be reset. + @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. =20 **/ EFI_STATUS -- 2.11.0