From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A6F5221786B0 for ; Thu, 30 Nov 2017 18:37:47 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2017 18:42:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,343,1508828400"; d="scan'208";a="182251751" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 30 Nov 2017 18:42:13 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Nov 2017 18:42:13 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Nov 2017 18:42:12 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 1 Dec 2017 10:42:10 +0800 From: "Zeng, Star" To: "Ni, Ruiyu" , "Gao, Liming" , Felix Poludov , "afish@apple.com" CC: "edk2-devel@lists.01.org" , "Zeng, Star" Thread-Topic: [edk2] edk2 interface deprecation policy Thread-Index: AdNp4pfr7+u/EK+jQZukLW6fR9eGA///rSQAgABYJgD//z16IP/+dw0Q//zkuPA= Date: Fri, 1 Dec 2017 02:42:09 +0000 Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BE7C9@shsmsx102.ccr.corp.intel.com> References: <9333E191E0D52B4999CE63A99BA663A00302B63C30@atlms1.us.megatrends.com> <9333E191E0D52B4999CE63A99BA663A00302B64F9B@atlms1.us.megatrends.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E188BBE@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAD9592@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAD9592@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: edk2 interface deprecation policy X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 02:37:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable How about the case below for example? They all have comments " This library= instance is no longer used and module using this library class should upda= te to directly ..." for a very long time (since 2009) and no one should use= them, when could they be removed? Literally, they seems useful, and people can only know they are deprecated = by looking into the comments. MdeModulePkg/Include/Library/RecoveryLib.h MdeModulePkg/Include/Library/S3Lib.h MdeModulePkg/Library/PeiS3LibNull MdeModulePkg/Library/PeiRecoveryLibNull IntelFrameworkModulePkg/Library/PeiRecoveryLib IntelFrameworkModulePkg/Library/PeiS3Lib Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni, = Ruiyu Sent: Friday, December 1, 2017 10:27 AM To: Gao, Liming ; Felix Poludov ; afi= sh@apple.com Cc: edk2-devel@lists.01.org Subject: Re: [edk2] edk2 interface deprecation policy I prefer to remove all deprecated items because I like clean:) But then lot= s of customer complains may come. So just provide my thoughts: Deprecated items can be separated into: 1. Definitions: E.g.: UgaDraw protocol, DriverConfiguration2 protocol Keep: But harm the newbie developers because they don't know which interf= aces should depend on. Remove: A pure world. But easy to cause build break. Yet easy to fix by downloading the d= efinitions from old revision. Proposal: Move all deprecated definitions to a DeprecatePkg/OldPkg.=20 2. Modules. E.g.: IntelFrameworkModulePkg/Universal/BdsDxe, IntelFrameworkM= odulePkg/Bus/Isa/* Keep: Increase feature owner's maintain effort. Cause confusing because new features won't be enabled in deprecate= d modules. Remove: A pure world. But easy to cause build break. Yet easy to fix by downloading the= definitions from old revision. Proposal: Keep it if in IntelFramework[Module]Pkg because in future the two = pkgs will be deprecated. Move it to DeprecatePkg/OldPkg if in Mde[Module]Pkg 3. Libraries: E.g.: IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportSta= tusCode Same as #2. So how about we create another GIT repo and store the DeprecatePkg/OldPkg. Old consumers can download old stuffs from the other GIT repo. Eventually the IntelFramework[Module]Pkg can be moved to that repo as well. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Gao, Liming > Sent: Friday, December 1, 2017 9:51 AM > To: Felix Poludov ; afish@apple.com > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] edk2 interface deprecation policy >=20 > Felix: > I agree to define the tag to specify the deprecated definition, library= and drivers. > If so, user can easily know which one is not used any more. But, I=20 > think we can still keep them in edk2 project, because they have no negati= ve impact. >=20 > Thanks > Liming > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 > >Of Felix Poludov > >Sent: Friday, December 01, 2017 6:12 AM > >To: afish@apple.com > >Cc: edk2-devel@lists.01.org > >Subject: Re: [edk2] edk2 interface deprecation policy > > > >I agree. It would be beneficial to have a mailing list discussion on=20 > >how to deal with the deprecated item. > >In some cases it would make sense to tag an interface as deprecated,=20 > >but keep in the code base for a while (6 month?) before actually deletin= g it. > > > >-----Original Message----- > >From: afish@apple.com [mailto:afish@apple.com] > >Sent: Thursday, November 30, 2017 11:57 AM > >To: Felix Poludov > >Cc: edk2-devel@lists.01.org > >Subject: Re: [edk2] edk2 interface deprecation policy > > > >Felix, > > > >I don't think we have one.... > > > >Adding new interfaces does not impact the downstream projects, but=20 > >depreciating interface can break stuff. Seems like it might at least=20 > >be a good idea to have a depreciation discussion on the mailing =20 > >list. I'm open to other suggestions.... > > > >Thanks, > > > >Andrew Fish > > > >> On Nov 30, 2017, at 6:00 AM, Felix Poludov wrote: > >> > >> Does edk2 have a policy regarding deprecation of interface=20 > >> definition > >headers? > >> I can see that definition of the UgaDraw protocol that was=20 > >> deprecated years > >ago (I believe in UEFI 2.0) is still part of the code base; yet,=20 > >definition of the SMM Communication ACPI Table that was deprecated=20 > >this year in UEFI 2.6B has already been removed. > >> > >> Please consider the environment before printing this email. > >> > >> The information contained in this message may be confidential and > >proprietary to American Megatrends, Inc. This communication is=20 > >intended to be read only by the individual or entity to whom it is=20 > >addressed or by their designee. If the reader of this message is not=20 > >the intended recipient, you are on notice that any distribution of=20 > >this message, in any form, is strictly prohibited. Please promptly=20 > >notify the sender by reply e-mail or by telephone at 770-246-8600,=20 > >and then delete or > destroy all copies of the transmission. > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > > > > > >Please consider the environment before printing this email. > > > >The information contained in this message may be confidential and=20 > >proprietary to American Megatrends, Inc. This communication is=20 > >intended to be read only by the individual or entity to whom it is=20 > >addressed or by their designee. If the reader of this message is not=20 > >the intended recipient, you are on notice that any distribution of=20 > >this message, in any form, is strictly prohibited. Please promptly=20 > >notify the sender by reply e-mail or by telephone at 770-246-8600,=20 > >and then delete or > destroy all copies of the transmission. > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel