From: "Zeng, Star" <star.zeng@intel.com>
To: Zenith432 <zenith432@users.sourceforge.net>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg: loose VA_COPY with no matching VA_END on a return path
Date: Mon, 11 Dec 2017 01:10:30 +0000 [thread overview]
Message-ID: <0C09AFA07DD0434D9E2A0C6AEB0483103B9C1D91@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <580761.1807684.1512839078048@mail.yahoo.com>
Reviewed-by: Star Zeng <star.zeng@intel.com> and pushed at a0460be7e88539649cd10139491dd6955c54fb14.
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zenith432
Sent: Sunday, December 10, 2017 1:05 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH] MdeModulePkg: loose VA_COPY with no matching VA_END on a return path
In CheckRemainingSpaceForConsistencyInternal, one of the return paths leaves a loose VA_COPY with no matching VA_END.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zenith432 <zenith432@users.sourceforge.net>
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index f39be6b0..969df955 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1765,6 +1765,7 @@ CheckRemainingSpaceForConsistencyInternal (
//
// No enough space for Variable[Index].
//
+ VA_END (Args);
return FALSE;
}
//
--
2.14.3 (Apple Git-98)
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-12-11 1:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <580761.1807684.1512839078048.ref@mail.yahoo.com>
2017-12-09 17:04 ` [PATCH] MdeModulePkg: loose VA_COPY with no matching VA_END on a return path Zenith432
2017-12-11 1:10 ` Zeng, Star [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C09AFA07DD0434D9E2A0C6AEB0483103B9C1D91@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox